Description Expand link is showing by default [#2475283]

Hi All,

After enabling this module_filter module, we can see the module descriptions in the module list page. By default, all descriptions having the expand/collapse arrow attached in front of all the descriptions. Only we has to show the expand/collapse arrow when the descriptions text exceeds the column width or when showing some dependency modules under the description text.

Attaching the screenshot for reference.

Thanks,
Hemanth

Comment	File	Size	Author
#5	2475283-5.patch	1.83 KB	AkashKumar07
#1	module_filter_expand.jpg	155.74 KB	slhemanthkumar
#1	module_filter_7.x-2.x-dev.expand_issue-2475283.patch	3.94 KB	slhemanthkumar
	Expand-Collapse issue.jpg	163.98 KB	slhemanthkumar

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

slhemanthkumar CreditAttribution: slhemanthkumar at TATA Consultancy Services commented 21 April 2015 at 17:24

File	Size
module_filter_7.x-2.x-dev.expand_issue-2475283.patch	3.94 KB
module_filter_expand.jpg	155.74 KB

Hi All,

I solved the above issue and attaching the patch for the same. Please include this patch if any one facing the same issue.

Thanks,
Hemanth

Comment #2

slhemanthkumar CreditAttribution: slhemanthkumar at TATA Consultancy Services commented 21 April 2015 at 17:25

Status:

Active

» Needs review

Please review the above patch and push the changes in coming release.

Comment #3

slhemanthkumar CreditAttribution: slhemanthkumar at TATA Consultancy Services commented 23 April 2015 at 16:00

Comment #4

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented 8 January 2019 at 17:12

Status:

Needs review

» Needs work

1 file was hidden/shown/deleted

File	Size
module_filter_7.x-2.x-dev.expand_issue-2475283.patch	3.94 KB

The 4 year old patch module_filter.theme.inc needs work...

When trying to apply the patch with git apply:
error: unrecognized input

When trying to apply the patch with patch apply:

patch unexpectedly ends in middle of line
patch: **** Only garbage was found in the patch input.

Comment #5

AkashKumar07 CreditAttribution: AkashKumar07 at OpenSense Labs commented 12 November 2019 at 12:40

Status:

Needs work

» Needs review

File	Size
2475283-5.patch	1.83 KB

Here, reroll for #1. Please review.

Comment #6

andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commented 14 November 2019 at 11:32

Assigned:

Unassigned

» andrey.troeglazov

Comment #7

izmeez CreditAttribution: izmeez commented 10 January 2022 at 22:56

This patch makes sense as a cosmetic improvement but may be of limited use as it requires the module_filter configuration to show the module version in a separate column and then have modules existing that do not have additional info about module dependencies.

On a quick test with the latest module_filter-7.x-2.x-dev (2020-04-12) it appears to cause the description to be duplicated in the link column.