SQLite: Fix views\Tests\Handler\FilterStringTest

+++ b/core/lib/Drupal/Core/Database/Driver/sqlite/Statement.php
@@ -39,7 +39,10 @@ protected function getStatement($query, &$args = array()) {
+          if (is_float($value) || is_int($value) || (is_numeric($value) && $value < PHP_INT_MAX)) {

@@ -58,7 +61,10 @@ protected function getStatement($query, &$args = array()) {
+          if (is_float($value) || is_int($value) || (is_numeric($value) && $value < PHP_INT_MAX)) {

Nitpick: I think it should be possible cast $value == PHP_INT_MAX as well :P

For easier future fixes we might should have a custom unit test, what do you think? In case you think it would be not worth to test that nontrivial code,
or use the implicit test coverage we already have, set it please to RTBC.

Perfect, thank you!

Looks like we're missing a test case here for a ridiculously huge number-in-a-string? That's what this patch is intended to fix, yeah?

Ok, got it. It's the is_numeric() that's important here, not the PHP_INT_MAX. https://api.drupal.org/api/drupal/core!modules!search!src!Tests!SearchNu... contains various test cases, including:

    'over fifty characters' => '666666666666666666666666666666666666666666666666666666666666',

(hence this bug report :)) ...so we are good.

Committed and pushed to 8.0.x. Thanks!

Down, testbot

Looks fine for me, yeah this all is pretty tricky.

+++ b/core/modules/views/views.module
@@ -745,7 +745,18 @@ function _views_query_tag_alter_condition(AlterableInterface $query, &$condition
-        $condition['value'] = str_replace(array_keys($substitutions), array_values($substitutions), $condition['value']);
+        // We can not use a simple str_replace() here because it always returns
+        // a string and we have to keep the type of the condition value intact.
+        if (is_array($condition['value'])) {
+          foreach ($condition['value'] as &$value) {
+            if (is_string($value)) {
+              $value = str_replace(array_keys($substitutions), array_values($substitutions), $value);
+            }
+          }
+        }
+        elseif (is_string($condition['value'])) {
+          $condition['value'] = str_replace(array_keys($substitutions), array_values($substitutions), $condition['value']);
+        }
       }
     }
   }

I'm curious whether we should make a follow up to the database system to add such functionality (placeholder support), as I could imagine its much easier to be implemented internally than put on top of it, externally.

+++ b/core/modules/views/views.module
@@ -745,7 +745,18 @@ function _views_query_tag_alter_condition(AlterableInterface $query, &$condition
-        $condition['value'] = str_replace(array_keys($substitutions), array_values($substitutions), $condition['value']);
+        // We can not use a simple str_replace() here because it always returns
+        // a string and we have to keep the type of the condition value intact.
+        if (is_array($condition['value'])) {
+          foreach ($condition['value'] as &$value) {
+            if (is_string($value)) {
+              $value = str_replace(array_keys($substitutions), array_values($substitutions), $value);
+            }
+          }
+        }
+        elseif (is_string($condition['value'])) {
+          $condition['value'] = str_replace(array_keys($substitutions), array_values($substitutions), $condition['value']);
+        }

And there is no use case for using substitutions on non string values?

Well yeah, in case you already have the number you achieved what you need to know.

Thanks for having a think about it @dawehner and @amateescu. Committed 19a7f81 and pushed to 8.0.x. Thanks!