Update SimpleTest for coding standards changes. [#247423]

Comment	File	Size	Author
#10	simpletest_coding_standards.patch	81.97 KB	boombatower

#4	simpletest_coding_standards.patch	28.17 KB	boombatower

Comment #1

boombatower CreditAttribution: boombatower commented 16 April 2008 at 21:00

Priority:

Critical

» Normal

This is really something quite minor. Just a spacing issue. If someone would like to run a regular expression on the code or w/e they did on core and make a patch after confirming it doesn't mess anything up that would be great.

I think getting unit testing working and such is our major concern.

Log in or register to post comments

Comment #2

catch

he/him

English

CreditAttribution: catch commented 21 April 2008 at 12:46

Title:	Update for coding standards changes.	» Update SimpleTest for coding standards changes.
Project:	SimpleTest	» Drupal core
Version:		» 7.x-dev
Component:	Code	» simpletest.module

Log in or register to post comments

Comment #3

boombatower CreditAttribution: boombatower commented 28 April 2008 at 21:14

I assume there was a regular expression or script that was run on core. If so would someone mind running that on SimpleTest?

Log in or register to post comments

Comment #4

boombatower CreditAttribution: boombatower commented 6 May 2008 at 23:38

Status:

Active

» Reviewed & tested by the community

File	Size
simpletest_coding_standards.patch	28.17 KB

This fixes all the files in the simpletest directory. I will work on all the tests in a later patch.

Log in or register to post comments

Comment #5

Dries CreditAttribution: Dries commented 7 May 2008 at 06:51

Does this clash with the rewrite of the Simpletest framework that dimitri et al are working on?

Log in or register to post comments

Comment #6

boombatower CreditAttribution: boombatower commented 8 May 2008 at 19:11

Not sure, I am not actively involved in the framework rewrite.

I suppose the test files themselves for sure could have this done which I will work on.

I was thinking that since the rewrite will take some time this could be committed now. It doesn't change the code logic or anything important, just the appending . (dot) standard.