Problem/Motivation

drupal_render() was marked as deprecated, though its still called in quite some places.

Proposed resolution

  1. Avoid rendering manually by letting the template who is printing the variable render it.
  2. Inject the renderer service into service, which uses drupal_render()
  3. Use \Drupal::service('renderer')->render() for old prodecural code.

Remaining tasks

  1. Find all the actionable fixes: Search for drupal_render(
  2. Create a Patch
  3. Review

User interface changes

None

API changes

None

Files: 
CommentFileSizeAuthor
#1 replace_all-2473819-1.patch2.06 KBwillzyx
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 91,451 pass(es). View

Comments

willzyx’s picture

FileSize
2.06 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 91,451 pass(es). View
xjm’s picture

Version: 8.0.x-dev » 8.1.x-dev

Thanks @willzyx for all your work on these! Unfortunately, these issues need to be postponed to 8.1.x at least. See the allowed beta changes policy and the comment in #2393329-39: Replace all drupal_render calls with the service, and inject it, if possible..

xjm’s picture

Status: Needs review » Postponed
xjm’s picture

Status: Postponed » Closed (duplicate)

Actually, per discussion with @alexpott and @webchick, we should do these conversions in a single patch in #2393329: Replace all drupal_render calls with the service, and inject it, if possible..