Currently, a lot of our description texts aren't complete sentences (which is fine) but still end with a period (which isn't). We should remove the periods from the end of strings that don't form complete sentences.

Example (from search_api.processor.schema.yml):

      label: 'Text/HTML that will be prepended to all occurrences of search keywords in highlighted text.'

This is no sentence (it lacks a preposition), so shouldn't end with a period.

To fix, probably just search for the regex \.['"] and review all occurences.
This won't find comments, but that's on purpose: comments should always form complete sentences, and I think they're fine already.

CommentFileSizeAuthor
#4 search_api_sentence-2473757-4.patch19.15 KBrosinegrean
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yogen.prasad’s picture

Assigned: Unassigned » yogen.prasad
yogen.prasad’s picture

Assigned: yogen.prasad » Unassigned
rosinegrean’s picture

Assigned: Unassigned » rosinegrean
rosinegrean’s picture

Status: Active » Needs review
FileSize
19.15 KB

  • drunken monkey committed 7b130c2 on 8.x-1.x authored by prics
    Issue #2473757 by prics, drunken monkey: Fixed non-sentences ending with...

  • drunken monkey committed 36677ea on 8.x-1.x
    Follow-up to #2473757 by drunken monkey: Fixed some more non-sentences...
drunken monkey’s picture

Status: Needs review » Fixed

Thanks, good job!
I only spotted a few oversights or mistakes. There's probably still some left, but we can fix those when we spot them, I guess.
So, committed.
Thanks again!

  • drunken monkey committed ab97436 on 8.x-1.x
    Follow-up to #2473757 by drunken monkey: Fixed unit tests again.
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.