Currently, a lot of our description texts aren't complete sentences (which is fine) but still end with a period (which isn't). We should remove the periods from the end of strings that don't form complete sentences.
Example (from search_api.processor.schema.yml
):
label: 'Text/HTML that will be prepended to all occurrences of search keywords in highlighted text.'
This is no sentence (it lacks a preposition), so shouldn't end with a period.
To fix, probably just search for the regex \.['"]
and review all occurences.
This won't find comments, but that's on purpose: comments should always form complete sentences, and I think they're fine already.
Comment | File | Size | Author |
---|---|---|---|
#4 | search_api_sentence-2473757-4.patch | 19.15 KB | rosinegrean |
Comments
Comment #1
yogen.prasad CreditAttribution: yogen.prasad commentedComment #2
yogen.prasad CreditAttribution: yogen.prasad commentedComment #3
rosinegrean CreditAttribution: rosinegrean commentedComment #4
rosinegrean CreditAttribution: rosinegrean commentedComment #7
drunken monkeyThanks, good job!
I only spotted a few oversights or mistakes. There's probably still some left, but we can fix those when we spot them, I guess.
So, committed.
Thanks again!