Hi,

Following the very nice session of lussoluca in #drupaldevdays 2015, I've tested the webprofiler (-dev versions for it as well as core), and as of yesterday morning, uninstall contact core module is breaking the site.

How to reproduce : install a "standard" profile, enable webprofiler, uninstall contact module. I've done all that with the UI, I don't know if that matters.
I've successfully uninstalled other modules like help or history without any issue.

When trying to clear the cache with drush, the following error message is raised : Drupal\Component\Plugin\Exception\PluginNotFoundException: The "contact_form" entity type does not exist. in Drupal\Core\Entity\EntityManager->getDefinition() (line 257 of /var/www/drupal8/core/lib/Drupal/Core/Entity/EntityManager.php).

CommentFileSizeAuthor
#10 impossible_to_uninstall-2473677-10.patch668 byteslussoluca
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
CreditAttribution: lussoluca commented
Status: Active » Postponed (maintainer needs more info)

Hi Simon,
I cannot reproduce the bug. Do you have created some contact form before uninstall the module?

Simon Georges’s picture

Simon Georges CreditAttribution: Simon Georges at Makina Corpus commented

No, only the one coming with the standard install profile. I'll try with an updated version of both HEAD and web_profiler, and come back.

Simon Georges’s picture

Simon Georges CreditAttribution: Simon Georges at Makina Corpus commented
Status: Postponed (maintainer needs more info) » Active

I have the exact same issue right now (vanilla install of current -dev version of Webprofiler and current core HEAD). Do you want some infos about my configuration.

lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
CreditAttribution: lussoluca commented

Do you want some infos about my configuration

Yes please (OS, web server, php version, ...)

Thanks

Simon Georges’s picture

Simon Georges CreditAttribution: Simon Georges at Makina Corpus commented

Ubuntu 14.04 64bits, Apache 2.4.7, PHP 5.5.9 (all Ubuntu packages).

Additional extensions :
05-opcache.ini, 10-pdo.ini, 20-curl.ini, 20-gd.ini, 20-intl.ini, 20-json.ini, 20-ldap.ini, 20-mysql.ini, 20-mysqli.ini, 20-pdo_mysql.ini, 20-pdo_sqlite.ini, 20-readline.ini, 20-sqlite3.ini, 20-tidy.ini, 20-xdebug.ini, 20-xsl.ini, 90-blackfire.ini.

lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
CreditAttribution: lussoluca commented
Project: WebProfiler » Devel
Component: Code » webprofiler

Webprofiler has been merged with Devel.

tobiberlin’s picture

tobiberlin
Primary language German
Location Berlin, Germany
CreditAttribution: tobiberlin commented

Same issue here: I simply started a vanilla Dupal project with standard profile and de-installed Conatct module. No when I visit admin/modules/uninstall I see the following error:

Drupal\Core\Database\DatabaseExceptionWrapper: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'ixdsd8.comment' doesn't exist: SELECT base_table.cid AS cid, base_table.cid AS base_table_cid FROM {comment} base_table GROUP BY base_table.cid LIMIT 1 OFFSET 0; Array ( ) in Drupal\Core\Entity\ContentEntityStorageBase->hasData() (line 77 of core\lib\Drupal\Core\Entity\ContentEntityStorageBase.php).

Drupal\Core\Database\Statement->execute(Array, Array)
Drupal\Core\Database\Connection->query('SELECT base_table.cid AS cid, base_table.cid AS base_table_cid
FROM 
{comment} base_table
GROUP BY base_table.cid
LIMIT 1 OFFSET 0', Array, Array)
Drupal\Core\Database\Driver\mysql\Connection->query('SELECT base_table.cid AS cid, base_table.cid AS base_table_cid
FROM 
{comment} base_table
GROUP BY base_table.cid
LIMIT 1 OFFSET 0', Array, Array)
Drupal\Core\Database\Query\Select->execute()
Drupal\Core\Entity\Query\Sql\Query->result()
Drupal\Core\Entity\Query\Sql\Query->execute()
Drupal\Core\Entity\ContentEntityStorageBase->hasData()
Drupal\Core\Entity\ContentUninstallValidator->validate('comment')
Drupal\Core\Extension\ModuleInstaller->validateUninstall(Array)
Drupal\Core\ProxyClass\Extension\ModuleInstaller->validateUninstall(Array)
Drupal\system\Form\ModulesUninstallForm->buildForm(Array, Object)
call_user_func_array(Array, Array)
Drupal\Core\Form\FormBuilder->retrieveForm('system_modules_uninstall', Object)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object)
Drupal\Core\Controller\FormController->getContentResult(Object, Object)
call_user_func_array(Array, Array)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
call_user_func_array(Object, Array)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1)
Stack\StackedHttpKernel->handle(Object, 1, 1)
Drupal\Core\DrupalKernel->handle(Object)
gmario’s picture

gmario CreditAttribution: gmario commented

Hi,

as Simon Georges reports, this error show up but if you uninstall contact from drush everything works fine.

a presto
gmario

gmario’s picture

gmario CreditAttribution: gmario commented

update:

another simple solution is to rebuild the cache.

gmario

lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
CreditAttribution: lussoluca commented
Status: Active » Needs review
FileSize
impossible_to_uninstall-2473677-10.patch668 bytes

This patch disable Webprofiler on /admin/modules/uninstall/* routes and this seems to resolve the issue.

gmario’s picture

gmario CreditAttribution: gmario commented

Hi,

just tested the patch (drupal 8.0.2 + 8.x-1.x-dev ), works as expected.

gmario

  • lussoluca committed 0182817 on 8.x-1.x 
    Issue #2473677 by lussoluca: Impossible to uninstall Contact
lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
CreditAttribution: lussoluca commented
Status: Needs review » Closed (fixed)

Committed and pushed to 8.x-1.x.
Thanks!

lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
CreditAttribution: lussoluca commented
Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.