This is a side issue of #2467413: Refactor count API into FlagCountService with the intent of separating out some of the API changes for independant inspection.

From an interface perspective, formally FlaggingEvent::flag/event are now publicly readable. [ write access is unchanged.]

and the new methods are :-

FlaggingEvent::getEvent()
FlaggingEvent::getFlag()

[ In the other issue a newly created FlagCounterSubscriber is about to use these methods. ]

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

martin107’s picture

Issue summary: View changes
Status: Active » Needs review
FileSize
673 bytes
martin107’s picture

FileSize
656 bytes
408 bytes

Complying with request 1 from https://www.drupal.org/node/2467413#comment-9837645

opps should have seen that earlier:)

joachim’s picture

Status: Needs review » Fixed

Cool!

Nice simple patch -- committed!

  • joachim committed b976c8a on 8.x-4.x authored by martin107
    Issue #2473349 by martin107: Added getters for FlaggingEvent::flag and...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.