Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
It would be nice to be able to stop environment_indicator from putting an overlay on the favicon for certain environments, especially environments where users who can see the favicon are frequently logged in.
Proposed resolution
While there are internal options for turning it on and off, it's locked to "on":
$js_settings = array(
'environment_indicator' => array(
'addFavicon' => TRUE,
// Get the first letter out of the name.
'faviconLabel' => $match['name'][0],
'faviconColor' => $match['color'],
'faviconTextColor' => $match['text_color'],
),
);
It should be pretty easy to add a setting to turn it off.
Remaining tasks
Write a patch.- Review and RTBC.
- Commit.
User interface changes
Adds an option to the settings form at admin/config/development/environment-indicator/settings
which allows administrators to disable the favicon overlay.
API changes
None.
Comment | File | Size | Author |
---|---|---|---|
#2 | make_favicon_overlay-2471923-1.patch | 2.97 KB | mparker17 |
Comments
Comment #1
mparker17Patch attached. Feedback welcome.
Comment #2
mparker17Should actually attach patch...
Comment #3
t0xicCode CreditAttribution: t0xicCode at OpenConcept Consulting Inc. commentedLooks fine. I'll test it later tonight.
Comment #4
t0xicCode CreditAttribution: t0xicCode at OpenConcept Consulting Inc. commentedI actually reviewed this last week, but forgot to RTBC.
It's a simple change that looks good and works fine.
Comment #5
e0ipsoThanks for your contribution! I'm sorry it took me so long to get to this.
Comment #7
mparker17No problem! :)
Marking as fixed since it's committed now.
Comment #9
coolestdude1 CreditAttribution: coolestdude1 as a volunteer commentedMarked #2297615: Extract Favicon/Shortcut Icon Functionality into Addon Module as duplicate of this issue.
Thanks!