Problem/Motivation

It would be nice to be able to stop environment_indicator from putting an overlay on the favicon for certain environments, especially environments where users who can see the favicon are frequently logged in.

Proposed resolution

While there are internal options for turning it on and off, it's locked to "on":

      $js_settings = array(
        'environment_indicator' => array(
          'addFavicon' => TRUE,
          // Get the first letter out of the name.
          'faviconLabel' => $match['name'][0],
          'faviconColor' => $match['color'],
          'faviconTextColor' => $match['text_color'],
        ),
      );

It should be pretty easy to add a setting to turn it off.

Remaining tasks

  1. Write a patch.
  2. Review and RTBC.
  3. Commit.

User interface changes

Adds an option to the settings form at admin/config/development/environment-indicator/settings which allows administrators to disable the favicon overlay.

API changes

None.

CommentFileSizeAuthor
#2 make_favicon_overlay-2471923-1.patch2.97 KBmparker17
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mparker17’s picture

Assigned: mparker17 » Unassigned
Issue summary: View changes
Status: Active » Needs review

Patch attached. Feedback welcome.

mparker17’s picture

Should actually attach patch...

t0xicCode’s picture

Looks fine. I'll test it later tonight.

t0xicCode’s picture

Status: Needs review » Reviewed & tested by the community

I actually reviewed this last week, but forgot to RTBC.

It's a simple change that looks good and works fine.

e0ipso’s picture

Thanks for your contribution! I'm sorry it took me so long to get to this.

  • e0ipso committed 822398a on 7.x-2.x authored by mparker17
    Issue #2471923 by mparker17: Make favicon overlay optional
    
mparker17’s picture

Status: Reviewed & tested by the community » Fixed

No problem! :)

Marking as fixed since it's committed now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

coolestdude1’s picture