Replace drupal_render calls in core/modules/simpletest [#2471913]

Parent issue: #2393329: Replace all drupal_render calls with the service, and inject it, if possible.

Problem/Motivation

drupal_render() was marked as deprecated, though its still called in quite some places.

Proposed resolution

Avoid rendering manually by letting the template who is printing the variable render it.
Inject the renderer service into service, which uses drupal_render()
Use \Drupal::service('renderer')->render() for old prodecural code.

Remaining tasks

Find all the actionable fixes: Search for drupal_render(
Create a Patch
Review

User interface changes

None

API changes

None

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category	Task because this removes usages of a deprecated function.
Issue priority	Not critical because the function in question is not to be removed in this release cycle.

Comment	File	Size	Author
#2	2471913_1.patch	8.83 KB	Mile23
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Mile23

English

Seattle, WA

CreditAttribution: Mile23 commented 15 April 2015 at 20:14

Issue summary:

View changes

Comment #2

Mile23

English

Seattle, WA

CreditAttribution: Mile23 commented 15 April 2015 at 21:30

Assigned:	Mile23	» Unassigned
Status:	Active	» Needs review

File	Size
2471913_1.patch	8.83 KB

First-pass. Passes most of the simpletest tests... Let's see how it fares with the testbot.

Comment #3

Mile23

English

Seattle, WA

CreditAttribution: Mile23 commented 15 April 2015 at 21:48

Issue tags:

-Needs beta evaluation

Comment #4

willzyx CreditAttribution: willzyx commented 18 April 2015 at 09:30

+++ b/core/modules/simpletest/src/Form/SimpletestTestForm.php
@@ -18,6 +20,30 @@
+   * Rendering service.
+   *
+   * @var Drupal\Core\Render\Renderer
+   */
+  protected $renderer;

leading slash is missing. Should be @var \Drupal\Core\Render\Renderer