Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Action "Remove user role" needs to be ported to Rules 8.x-3.x.
Action "Remove user role" needs to be ported to Rules 8.x-3.x.
Comments
Comment #1
a.milkovskyIt's mine now
Comment #2
a.milkovskynot anymore :)
Comment #3
Martin Mayer CreditAttribution: Martin Mayer commentedComment #4
katzillaComment #5
a.milkovskyyou can check https://www.drupal.org/node/2348839 which is almost ready
Comment #6
katzillaThanks @a.milkovsky - that helped a lot ;-)
Added a pr here: https://github.com/fago/rules/pull/182
Please review - not sure if I covered all testcases, because it was my first unittest.
Comment #7
dasjoThanks for working on this one? :) Please don't forget to unassign
Comment #8
dasjoThe question mark in the previous comment should be ! instead :)
Setting to needs work based on the comments that have been made on the pull request.
Comment #9
Anonymous (not verified) CreditAttribution: Anonymous as a volunteer commentedHave picked this up over at https://github.com/fago/rules/pull/214 - re-rolled to work with latest rules & tidied up code styling. See my notes as may need further tests.
Comment #10
klausiThanks, left comments in the pull request!
Comment #11
Anonymous (not verified) CreditAttribution: Anonymous as a volunteer commentedThanks, have addressed the issues, updated the code & squashed the commits.
Comment #12
klausiThanks, left some comments in the pull request!
Comment #13
Anonymous (not verified) CreditAttribution: Anonymous as a volunteer commentedHave rewritten the tests using Prophecy. Altered the first one to be like the UserRoleAddTest so it tests autosave too. Merged the commits so should be ready to go if nothing else needs fixing/adding.
Comment #14
klausimerged, thanks!