Action "Remove user role" needs to be ported to Rules 8.x-3.x.

Comments

a.milkovsky’s picture

a.milkovsky
he/him
Location UTC +2
CreditAttribution: a.milkovsky commented
Assigned: Unassigned » a.milkovsky

It's mine now

a.milkovsky’s picture

a.milkovsky
he/him
Location UTC +2
CreditAttribution: a.milkovsky commented
Assigned: a.milkovsky » Unassigned

not anymore :)

Martin Mayer’s picture

Martin Mayer CreditAttribution: Martin Mayer commented
Assigned: Unassigned » Martin Mayer
katzilla’s picture

katzilla
she/her
Primary language German
Location Göttingen, Germany
CreditAttribution: katzilla at Reinblau commented
Assigned: Martin Mayer » katzilla
a.milkovsky’s picture

a.milkovsky
he/him
Location UTC +2
CreditAttribution: a.milkovsky commented

you can check https://www.drupal.org/node/2348839 which is almost ready

katzilla’s picture

katzilla
she/her
Primary language German
Location Göttingen, Germany
CreditAttribution: katzilla at Reinblau commented
Status: Active » Needs review

Thanks @a.milkovsky - that helped a lot ;-)

Added a pr here: https://github.com/fago/rules/pull/182
Please review - not sure if I covered all testcases, because it was my first unittest.

dasjo’s picture

dasjo
he/him
Primary language German
Location Zurich
CreditAttribution: dasjo commented
Assigned: katzilla » Unassigned

Thanks for working on this one? :) Please don't forget to unassign

dasjo’s picture

dasjo
he/him
Primary language German
Location Zurich
CreditAttribution: dasjo commented
Status: Needs review » Needs work

The question mark in the previous comment should be ! instead :)

Setting to needs work based on the comments that have been made on the pull request.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous as a volunteer commented
Status: Needs work » Needs review

Have picked this up over at https://github.com/fago/rules/pull/214 - re-rolled to work with latest rules & tidied up code styling. See my notes as may need further tests.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Status: Needs review » Needs work

Thanks, left comments in the pull request!

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous as a volunteer commented
Status: Needs work » Needs review

Thanks, have addressed the issues, updated the code & squashed the commits.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Status: Needs review » Needs work

Thanks, left some comments in the pull request!

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous as a volunteer commented
Status: Needs work » Needs review

Have rewritten the tests using Prophecy. Altered the first one to be like the UserRoleAddTest so it tests autosave too. Merged the commits so should be ready to go if nothing else needs fixing/adding.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Status: Needs review » Fixed

merged, thanks!

  • klausi committed 8a257e0 on 8.x-3.x authored by stevepurkiss 
    Issue #2471645 by stevepurkiss, katzilla: Port "Remove user role" action...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.