We currently have the following structure for Rules Plugins:

  • Plugin
    • Action
    • Condition
    • RulesDataProcessor
    • RulesExpression

Should this be:

  • Plugin
    • Action
    • Condition
    • DataProcessor
    • Expression

?

Comments

dasjo’s picture

dasjo
he/him
Primary language German
Location Zurich
CreditAttribution: dasjo commented

Yeah, I would say so.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Assigned: Unassigned »

Working on this.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Active » Needs review

I've created a pull request here:

https://github.com/fago/rules/pull/169

It failed travis ci but I think that might be because I'm renaming what it's trying to find, perhaps.

fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago commented
Status: Needs review » Closed (won't fix)

DataProcessor
Expression

Nope, we'll have to use Rules prefixes for the plugin types provided by Rules - such that we avoid conflicts. Condition and Action is exposed by core, that's why it is different.