EntityInterface::getEntityType() gets you a type object; EntityInterface::getEntityTypeId() gets you an ID string.

Our getFlaggableEntityType() is confusingly named when compared with this.

CommentFileSizeAuthor
#1 getFlaggable-2471142-1.patch2.97 KBmartin107
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

martin107’s picture

Status: Active » Needs review
FileSize
2.97 KB

A global replace call tells me 6 instances fixed.

Visually I have given it the once over ... all annotations seems fine.

FlagSimpleTest passes... triggering testbot to see if I have missed anything silly.

martin107’s picture

Status: Needs review » Reviewed & tested by the community

Ok so after sleeping on it - I won't RTBC my own patch :)

joachim’s picture

Status: Reviewed & tested by the community » Fixed

tut tut... :)

It's a simple change, and I confirm that a grep for 'getFlaggableEntityType\b' shows nothing. So committing this. Thanks for the patch!

  • joachim committed e2662ad on 8.x-4.x authored by martin107
    Issue #2471142 by martin107: Renamed getFlaggableEntityType() to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.