Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Currently the date filter handler uses constant APACHESOLR_VIEWS_DATE_ISO8601, which was originally copied from facetapi module: FACETAPI_DATE_ISO8601. This is not needed as there already is a perfectly good function: apachesolr_date_iso().
Remove all instances of APACHESOLR_VIEWS_DATE_ISO8601, and remove the constant.
Comment | File | Size | Author |
---|---|---|---|
#1 | apachesolr_views-remove-facetapi-dependency-2470487-1.patch | 1.42 KB | steveworley |
Comments
Comment #1
steveworley CreditAttribution: steveworley commentedOpting to use
apachesolr_iso_date
as opposed to creating the date object and calling format.
Comment #2
MiroslavBanov CreditAttribution: MiroslavBanov commentedThis was fixed in #1991722: Dates are malformed due to undefined define: FACETAPI_DATE_ISO8601 in commit e02d95f. It is part of the current recommended release as well of HEAD.
Comment #3
MiroslavBanov CreditAttribution: MiroslavBanov commentedThis may be a cleaner solution. We can get rid of the constant as well.
Comment #4
MiroslavBanov CreditAttribution: MiroslavBanov commentedThere is no dependency, as the constant is APACHESOLR_VIEWS_DATE_ISO8601, and it is part of the filter handler. Changing the issue type, and description of the task.
The patch #1 does not convert all instances of the usage, so it needs work.
Comment #5
MiroslavBanov CreditAttribution: MiroslavBanov commented