Currently the date filter handler uses constant APACHESOLR_VIEWS_DATE_ISO8601, which was originally copied from facetapi module: FACETAPI_DATE_ISO8601. This is not needed as there already is a perfectly good function: apachesolr_date_iso().

Remove all instances of APACHESOLR_VIEWS_DATE_ISO8601, and remove the constant.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

steveworley’s picture

Opting to use apachesolr_iso_date as opposed to creating the date object and calling format.

MiroslavBanov’s picture

This was fixed in #1991722: Dates are malformed due to undefined define: FACETAPI_DATE_ISO8601 in commit e02d95f. It is part of the current recommended release as well of HEAD.

MiroslavBanov’s picture

Status: Active » Needs review

This may be a cleaner solution. We can get rid of the constant as well.

MiroslavBanov’s picture

Title: Date filter handler has a dependency on facetapi. » Rework date filter handler to use apachesolr_date_iso()
Category: Bug report » Feature request
Issue summary: View changes
Status: Needs review » Needs work

There is no dependency, as the constant is APACHESOLR_VIEWS_DATE_ISO8601, and it is part of the filter handler. Changing the issue type, and description of the task.

The patch #1 does not convert all instances of the usage, so it needs work.

MiroslavBanov’s picture

Issue summary: View changes