Hi,

For a unknown reason yet after a week of being sick at home without any access to the Aegir at work, I noticed that my servers were having duplicated IP addresses. Hundreds of them.

I made a small patch to fix this issue. There's plenty of way to remove duplicates from a database, this is one way to do it, I hope this is right.

CommentFileSizeAuthor
#1 issue-2469901.patch677 bytesPol
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pol’s picture

Pol
the/that
Location Brussels
CreditAttribution: Pol commented
Status: Active » Needs review
FileSize
issue-2469901.patch677 bytes
Pol’s picture

Pol
the/that
Location Brussels
CreditAttribution: Pol commented
Issue summary: View changes
ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
CreditAttribution: ergonlogic commented
Status: Needs review » Needs work

I'm not sure that de-duplicating the IP table is necessarily the way to go. I think we'd be better off tracking down why the additional IP addresses are being assigned, and fixing that. I've seen this behaviour in Aegir 2.x with automated backups, so there might be some bug in that code too.

One reason not to de-dupe IP addresses is that, for (pre-SNI) SSL, for example, we need to have an IP address to bind per certificate; but duplicate IPs work just fine, in that context. Admittedly, that's a terribly ugly work-around. But I believe people are using and relying on it.

In the long run, the plan is to drop IP addresses entirely, and move to SNI. See #1926520: Support Server Name Indication (SNI) for SSL for more discussion and background on that.

Pol’s picture

Pol
the/that
Location Brussels
CreditAttribution: Pol commented

Hi,

This morning I noticed something.

When phing copies the new platform files from the Jenkins to Aegir, it runs these 3 commands:

drush provision-save '@${platform.alias}' --root='${platform.directory}' --context_type='platform' --makefile='${aegir.directories.platforms}/${platform.alias}/profiles/${drupal.profile}/${drupal.make.file}'
drush '@${platform.alias}' provision-verify
drush @hostmaster hosting-import '@${platform.alias}'

(the variable are replaced automatically by Phing when running)

This will run the platform verify task twice, you can see that on the screenshot here: https://drive.google.com/file/d/0B7ugUjBv1lqHeWx0MFhMMzNsRkk/view?usp=sh...

My questions are:

What are the command to run to import a platform properly ?
Are these three commands ok ?

I also noticed that running twice a verify command will duplicate the ip on the server linked to the platform.

helmo’s picture

helmo CreditAttribution: helmo at Initfour websolutions commented
Status: Needs work » Closed (outdated)

Sorry, but this is outdated... managing IP addresses is no longer needed with SNI and the future SSL implementation is done in https://gitlab.com/aegir/hosting_https