[D7] Webform Field Wrapper [#2469883]

The webform field wrapper provides an additional webform component that acts in a similar way to a fieldgroup, without being a fieldgroup. Fieldgroups are NOT the correct way to group fields together for presentational purposes, this is where Webform Filed Wrapper comes in.

In simple terms a new Filed Wrapper is added to the webform form components, any field can then group within it. From a markup prospective this provides themers with a containing div and some minor class additions to the contained form components which can be used for layout and visual design purposes.

https://www.drupal.org/sandbox/robwild/2430307

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/robwild/2430307.git

Comments

Comment #1

PA robot CreditAttribution: PA robot commented 13 April 2015 at 10:23

Status:

Active

» Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxrobwild2430307git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Comment #2

blacksnipe

Dutch

CreditAttribution: blacksnipe commented 29 April 2015 at 14:21

Status:

Needs work

» Reviewed & tested by the community

Automated Review

Seems okay. Nice work.

Manual Review

Individual user account: Follows the guidelines for individual user accounts.
No duplication: Does not cause module duplication and/or fragmentation.
Master Branch: Follows the guidelines for master branch.
Licensing: Follows the licensing requirements.
3rd party assets/code: Follows the guidelines for 3rd party assets/code.
README.txt/README.md: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review: Follows the guidelines for project length and complexity.
Secure code: Meets the security requirements.
Coding style & Drupal API usage: I'd check the unused variables on lines 98 and 99 of field_wrapper.inc.

This review uses the Project Application Review Template.

Comment #3

cweagans

He/Him

English

Boise, ID, USA

CreditAttribution: cweagans at NBCUniversal commented 16 July 2015 at 18:34

Status:

Reviewed & tested by the community

» Fixed

Thanks for your contribution!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.