Problem/Motivation

Neither node.vid, nor entity_test_rev.revision_id is defined as revisionable. This is IMO a bug.

Also, the setRevisionable method is not on any interface.

Proposed resolution

Enforce in EntityManager much like we enforce default_langcode. For now, we do this only for BaseFieldDefinition instances but that should be enough.

We do not resolve the interface in this issue.

CommentFileSizeAuthor
#19 2469533_19.patch5.06 KBchx
#17 2469533_17.patch4.94 KBchx
#11 2469533_10.patch3.43 KBchx
#7 2469533_8.patch1.24 KBchx
#6 2469533_6.patch1.24 KBchx
#3 2469533_2.patch735 byteschx
#2 2469533_2.patch1.93 KBchx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago commented

yes, revision id should be revisionable as it's stored by revision. I remember I already filed an issue for that, but I cannot find it right now :/

Regarding the missing setters in field definition interface: Most things just need read access, but sometimes we have a need a setters. But this is a general problem and does not only apply for revisionable. We should stick with what we have here to keep things consistent and solve this over at #2346329: hook_entity_base_field_info_alter() and hook_entity_bundle_field_info_alter() are documented to get a parameter that doesn't implement an interface with setter methods.

chx’s picture

chx CreditAttribution: chx at MongoDB commented
Issue summary: View changes
Status: Active » Needs review
FileSize
2469533_2.patch1.93 KB
chx’s picture

chx CreditAttribution: chx at MongoDB commented
FileSize
2469533_2.patch735 bytes

Wrong patch.

The last submitted patch, 2: 2469533_2.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 3: 2469533_2.patch, failed testing.

chx’s picture

chx CreditAttribution: chx at MongoDB commented
Status: Needs work » Needs review
FileSize
2469533_6.patch1.24 KB

That's fun: we have a logicexception if the revision_id is revisionable...

chx’s picture

chx CreditAttribution: chx at MongoDB commented
FileSize
2469533_8.patch1.24 KB

The last submitted patch, 6: 2469533_6.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 7: 2469533_8.patch, failed testing.

chx’s picture

chx CreditAttribution: chx at MongoDB commented
Status: Needs work » Needs review

Thanks @plach for pointing me to the right place.

chx’s picture

chx CreditAttribution: chx at MongoDB commented
FileSize
2469533_10.patch3.43 KB
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Status: Needs review » Reviewed & tested by the community

Looks good

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented

It's a bug we need tests here I think.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests

Agreed. We don't want to accidentally make it not revisionable again.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented

There is plenty of implicit test coverage if we just turn revisionability to false on the definition.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented

So can we have fail patch?

chx’s picture

chx CreditAttribution: chx at MongoDB commented
Status: Needs work » Needs review
Issue tags: -Needs tests
FileSize
2469533_17.patch4.94 KB

Status: Needs review » Needs work

The last submitted patch, 17: 2469533_17.patch, failed testing.

chx’s picture

chx CreditAttribution: chx at MongoDB commented
Status: Needs work » Needs review
FileSize
2469533_19.patch5.06 KB

Status: Needs review » Needs work

The last submitted patch, 19: 2469533_19.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented

@chx: https://twitter.com/webchick/status/573274036093902848 :D

chx’s picture

chx CreditAttribution: chx at MongoDB commented

I will when it makes sense. Not yet.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Status: Needs work » Closed (duplicate)
Issue tags: +Bug Smash Initiative
Related issues: +#2975307: The revision ID field should be flagged as revisionable

I asked about this in #bugsmash and acbramley and catch agree this is a duplicate of #2975307: The revision ID field should be flagged as revisionable and moving credit.