The plural of "Popup On Load" should be "Popups On Load" not "Popup On Loads".

CommentFileSizeAuthor
#2 2469239-popup_onload-override-content-tab-name.patch378 bytesjwilson3
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
CreditAttribution: jwilson3 at Bluespark for HowlRound commented

Looks like this text *might* be coming from entity api, we could override it with hook_form_alter() similar to #2469231: Missing local task (tab) for /admin/content/popup_onload page.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
CreditAttribution: jwilson3 at Bluespark for HowlRound commented
Status: Active » Needs review
FileSize
2469239-popup_onload-override-content-tab-name.patch378 bytes

This patch just simplifies the title to "Popups", because it is not very likely that there will ever be more than one kind of popup entity on a site, losing the specificity and pluralization problem of "Popup Onload". This is also similar to other tabs that often appear here on sites: "Files" "Media" etc.

Status: Needs review » Needs work

The last submitted patch, 2: 2469239-popup_onload-override-content-tab-name.patch, failed testing.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
CreditAttribution: jwilson3 at Bluespark for HowlRound commented
Status: Needs work » Closed (duplicate)

Going to close this as a duplicate of #2469231: Missing local task (tab) for /admin/content/popup_onload page, to make the patch easier to apply, and kill two birds with one stone.