These date back from 7.x-2.x:

        'description' => 'The flag type, usually one of "node", "comment", "user".',
...
        'description' => 'The unique ID of the content, usually either the {cid}, {uid}, or {nid}.',

The flag type can be any entity type. We can say something like "for example, 'node' or 'comment'". For the ID, we should just say something like 'the unique ID of the flagged entity'.

CommentFileSizeAuthor
#11 antique_field_drupal7_backport-2466539-11.patch1.87 KBjoekers
#6 antique_field-2466539-6.patch769 bytesjoekers
#2 antique_field_drupal7_backport-2466539-2.patch1.86 KBjoekers
#1 antique_field-2466539-1.patch765 bytesjoekers
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joekers’s picture

joekers
Primary language English
CreditAttribution: joekers at Zoocha commented
Assigned: Unassigned » joekers
FileSize
antique_field-2466539-1.patch765 bytes

Here's the Drupal 8 patch. I've never done a backport before - I guess I just create a patch for 7.x-3.x and upload it to this issue?

joekers’s picture

joekers
Primary language English
CreditAttribution: joekers at Zoocha commented
FileSize
antique_field_drupal7_backport-2466539-2.patch1.86 KB

Here's the 7.x-3.x patch.

joekers’s picture

joekers
Primary language English
CreditAttribution: joekers at Zoocha commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: antique_field_drupal7_backport-2466539-2.patch, failed testing.

joachim’s picture

joachim CreditAttribution: joachim commented

Great, thanks!

One thing though: curly braces go on table names, but not on table column names. So they're not needed here. I'd add a 'the' here too: 'for example, the uid, cid, or nid.'

+++ b/flag.install
@@ -19,12 +19,12 @@ function flag_schema() {
+        'description' => 'The unique ID of the flagged entity, for example {uid}, {cid}, {nid}.',

And for backports: yup. It's sometimes best to wait till the first patch is committed, and then backport it though, as it can save work! :) Furthermore, there is a possibility that the commit for the current branch can be git cherry-picked, requiring no further patch work. I'd say that's fairly likely here.

joekers’s picture

joekers
Primary language English
CreditAttribution: joekers at Zoocha commented
FileSize
antique_field-2466539-6.patch769 bytes

Ok I've made the changes from above. I'll leave the backport for now.

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Needs work » Needs review

Let's get the testbot to look at it just to play safe :)

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Needs review » Fixed

Committed.

Thanks again for working on this :)

  • joachim committed e6f3b4b on 8.x-4.x authored by joekers 
    Issue #2466539 by joekers: Fixed obsolete table field descriptions in...
joachim’s picture

joachim CreditAttribution: joachim commented
Status: Fixed » Patch (to be ported)

Sadly, the cherry-pick doesn't work at all, so we'll need a backported patch.

joekers’s picture

joekers
Primary language English
CreditAttribution: joekers at Zoocha commented
FileSize
antique_field_drupal7_backport-2466539-11.patch1.87 KB

Here's the D7 patch - the fields are used on other tables (not just the flag_counts table) so I updated those descriptions too. Is it worth me adding a hook_update_N() to update these field descriptions for users that already have the module installed?

joachim’s picture

joachim CreditAttribution: joachim commented
Version: 8.x-4.x-dev » 7.x-3.x-dev
Status: Patch (to be ported) » Needs review

> Is it worth me adding a hook_update_N() to update these field descriptions for users that already have the module installed?

No, I wouldn't think so.

joekers’s picture

joekers
Primary language English
CreditAttribution: joekers at Zoocha commented

I haven't checked back on this in a while - is there anything else I need to do?

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Needs review » Fixed

Nothing except nudge the maintainer, which you've done :)

Committed to 7.x-3.x. Thanks again!

  • joachim committed 7f8bc94 on 7.x-3.x authored by joekers 
    Issue #2466539 by joekers: Fixed obsolete table field descriptions in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.