Problem/Motivation

Currently views renders status, sticky as well as promoted as "On/off" by default.

Proposed resolution

Status should say "Published"/"Unpublished", promote should say "Promoted"/"Not promoted", and sticky should say "Sticky"/Not sticky.

In order to do that you can use NodeViewsData and provide default_formatter_settings for 'node_field_data][status][field' etc.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#10 default_title_for_node_boolean_flags--fix-2465623-10.patch4.88 KBDom.
#6 default_title_for_node_boolean_flags--tests-only-2465623-6.patch3.67 KBDom.
#6 default_title_for_node_boolean_flags--fix-2465623-6.patch4.88 KBDom.
#4 default_title_for_node_boolean_flags--2465623-4.patch1.22 KBDom.
#2 screenshot.png15.69 KBDom.
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Related issues: +#2462589: Provide test coverage for access checking of all views fields.
Dom.’s picture

Dom. CreditAttribution: Dom. commented
FileSize
screenshot.png15.69 KB

Few questions :

  1. Isn't it enough to have it using the "custom" option of "output Format" ?
  2. Would you rather like to have the default "On / Off" (1 on screenshot) worded as "Promoted / Not promoted" but still under the Boolean formatter (2) ?
  3. Would you rather like to have another formatter (2) as default "String" for instance that would say "Promoted / Not promoted" in the "Output format" in addition to the current Boolean ?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

Hi Dom! Well, I just think that we cannot add new entries there easily ... but I think defaulting it to the proper value using the custom option is probably the best idea at the moment.

Isn't it enough to have it using the "custom" option of "output Format" ?

Yeah the idea is to use the custom output formatter by default, and set it to Promote / unpromote for example by default.

    $data['file_managed']['status']['field']['default_formatter_settings'] = [
      'format' => 'custom',
      'format_custom_false' => $this->t('Temporary'),
      'format_custom_true' => t('Permanent'),
    ];

in core/modules/file/src/FileViewsData.php:63 shows how to do that.

Dom.’s picture

Dom. CreditAttribution: Dom. commented
Status: Active » Needs review
FileSize
default_title_for_node_boolean_flags--2465623-4.patch1.22 KB

Hi ! Thanks a lot for the tips. Here is a try patch for this issue.

Status: Needs review » Needs work

The last submitted patch, 4: default_title_for_node_boolean_flags--2465623-4.patch, failed testing.

Dom.’s picture

Dom. CreditAttribution: Dom. commented
Status: Needs work » Needs review
FileSize
default_title_for_node_boolean_flags--fix-2465623-6.patch4.88 KB
default_title_for_node_boolean_flags--tests-only-2465623-6.patch3.67 KB

Was not expecting that !!
Here is attached the fix patch (patch #4 + fix tests) and the tests-only patch (which is thus the interdiff with #4).

Status: Needs review » Needs work

The last submitted patch, 6: default_title_for_node_boolean_flags--tests-only-2465623-6.patch, failed testing.

The last submitted patch, 6: default_title_for_node_boolean_flags--fix-2465623-6.patch, failed testing.

Dom.’s picture

Dom. CreditAttribution: Dom. commented
Status: Needs work » Needs review
Dom.’s picture

Dom. CreditAttribution: Dom. commented
FileSize
default_title_for_node_boolean_flags--fix-2465623-10.patch4.88 KB

Re-upload same patch.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs review » Needs work

Wondering if this is still needed in 9.5?

Would it need core maintainer review to see if we should implement?

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.