Store functionality requires currencies, which come from commerce_price.
Since stores live in the commerce base module, that would require it to depend on commerce_price.

Instead, we want to make sure each module depends on commerce, but not the other way around.
So, we create commerce_store which depends on commerce_price, move the store functionality there.

Comments

vasike’s picture

Status: Active » Needs review
bojanz’s picture

Status: Needs review » Fixed

Merged.

  • bojanz committed 56c4b15 on 8.x-2.x
    Merge pull request #166 from vasike/8.x-2.x-commerce-store
    
    Isssues #...
  • vasike committed 88bc414 on 8.x-2.x
    Isssues #2465115 by bojanz, vasike : Move store functionality to its own...
rszrama’s picture

For what it's worth, Currencies were a part of commerce.module before, because we didn't make the assumption that all uses of currency info would be related to price fields. Did we have any specific goal in putting currency info in the price module this go round?

vasike’s picture

https://github.com/commerceguys/commerce/pull/170
i missed some text updates for the module changes.

  • bojanz committed 1db0836 on 8.x-2.x
    Merge pull request #170 from vasike/8.x-2.x-commerce-store
    
    Issue #...
  • vasike committed 47919f2 on 8.x-2.x
    Issue #2465115 by bojanz, vasike: Some corrections for module references...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.