Problem/Motivation

  • Facebook introduced new API 2.x
  • v1.0 will be deprecated on April 30, 2015
  • API 2.x has some difference with permission and variables
  • We need to make people understand, that the new Facebook API may break functionality.

Proposed resolution

I suggest to leave 7.x-1.x as it is, move all changes to 7.x-2.x and clean it up.

And commit all new changes to 7.x-2.x branch.

Related issues

Comments

mrded’s picture

mrded CreditAttribution: mrded commented
Issue summary: View changes
DarrellDuane’s picture

DarrellDuane CreditAttribution: DarrellDuane commented

Thanks mrded for outlining all of this. Please create this version/branch and commit it to the project.

mrded’s picture

mrded CreditAttribution: mrded commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
DarrellDuane’s picture

DarrellDuane CreditAttribution: DarrellDuane commented

I have changed the recommended releases for this project. the Recommended Dev release is now 7.x-2.x-dev,
the 7.x-1.x-dev is hidden and I can't imagine any reason to use it again.

In the coming days I or mrded will generate a production release of 7.x-2.0 and make it recommended. I would prefer to
get the items that are broken when I switched to FB Graph API 2.2 fixed before we do this, but I also know it is important to
do this before the FB Graph API 1.0 goes away on April 30th. I'd like to get these bugs fixed before April 20th, but either way
release 7.x-2.0 by April 20.

The main issue I'm waiting on resolution is https://www.drupal.org/node/2149661 before we release 7.x-2.0.

AlexKirienko’s picture

AlexKirienko CreditAttribution: AlexKirienko at WikiJob commented
Issue summary: View changes

#2448195: Update to FB API v2.0 - Friends now has a new permission was commited.
But I have found new change in v2.0 - #2470193: Update to FB API v2.0 - Permission user_tagged_places replaces user_location

AlexKirienko’s picture

AlexKirienko CreditAttribution: AlexKirienko at WikiJob commented
Issue summary: View changes
AlexKirienko’s picture

AlexKirienko CreditAttribution: AlexKirienko at WikiJob commented

I have uploaded patches for my tasks.

AlexKirienko’s picture

AlexKirienko CreditAttribution: AlexKirienko at WikiJob commented
Issue summary: View changes
AlexKirienko’s picture

AlexKirienko CreditAttribution: AlexKirienko at WikiJob commented
AlexKirienko’s picture

AlexKirienko CreditAttribution: AlexKirienko at WikiJob commented
Status: Active » Needs review

All critical issues was fixed.
First alpha was pushed - 7.x-2.0-alpha1 https://www.drupal.org/node/2472809

mrded’s picture

mrded CreditAttribution: mrded commented
Status: Needs review » Reviewed & tested by the community

No one complained so far. Make it live! :)

AlexKirienko’s picture

AlexKirienko CreditAttribution: AlexKirienko at WikiJob commented

Ok. I just want to test latest Darrel changes since rc1.

DarrellDuane’s picture

DarrellDuane CreditAttribution: DarrellDuane commented

HI Alex, yes please make sure the pop up works for you when you're first connecting via Facebook.

ighazali’s picture

ighazali CreditAttribution: ighazali commented

hi guys, get this message:

Unable to create a new account using your Facebook profile.

and in the log

Username not able to be retrieved from Facebook or be generated.

AlexKirienko’s picture

AlexKirienko CreditAttribution: AlexKirienko at WikiJob commented

Hi, @ighazali.

Can you please create separate issue for this bug ? I will be able to check and fix it then.

Thanks.

Chris Charlton’s picture

Chris Charlton
Primary language English
Location Los Angeles
CreditAttribution: Chris Charlton as a volunteer commented

I think this ticket can be cleaned up. :)

Chris Charlton’s picture

Chris Charlton
Primary language English
Location Los Angeles
CreditAttribution: Chris Charlton as a volunteer commented

Bump.

Chris Charlton’s picture

Chris Charlton
Primary language English
Location Los Angeles
CreditAttribution: Chris Charlton as a volunteer commented

This ticket seems old since it talks about 7.x-1.x branch of FBOAuth. Besides, all child tickets outlined above seem all fixed/closed.

Is there anything else holding this ticket from being closed?

DarrellDuane’s picture

DarrellDuane CreditAttribution: DarrellDuane commented
Status: Reviewed & tested by the community » Closed (outdated)