Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I've got a couple of minor improvements for the wsclient_tester module. The accompanying patch includes the following:
- Tester form should pass default variables set in client definition instead of being empty.
- The module should adhere to drupal code style (as much as possible).
- Tester form text fields should be wider so you can read longer variables.
Let me know what you think.
| Comment | File | Size | Author |
|---|---|---|---|
| wsclient-tester-improvements.patch | 7.31 KB | basvredeling |
Comments
Comment #1
dman CreditAttribution: dman commentedYep, I'm currently going through the open issues and trying to fold in as many open patches as I can right now - *because* I then want to do a code style update after that. :-)
It's a pain trying to fix the little phpcs complaints and then re-roll all the hard stuff, so doing it in the other order.
Patch looks clean and sane.
I'm working on setting up a bit more of a testing/regression harness for wsclient right now, so will try to apply it when I've settled that dust.
Comment #2
basvredelingDo you need a patch without the code style cleanup? So you can apply this patch and do your own code style fixes?
Comment #3
dman CreditAttribution: dman commentedNope, don't worry about that. There is nothing pending in the tester module issues that would conflict.
A *couple* of incidental tidy-ups as we go is fine when you are touching the code in the same place. I was just saying I've been holding myself back from max-fixing everything (Now I have PHPStorm highlighting it all for me and phpcbf on a hot-key)
I'm just saying - patch looks fine, I'm just trying to set up a testing methodology locally, and will put that thing in soon. Consider it accepted, just not applied yet.