views_handler_relationship_groupwise_max options_form_submit should be options_submit [#2463053]

I have discovered, that there is an error in views_handler_relationship_groupwise_max.inc, which results in the cache not being cleared when submitting the options form.

I found that I had to change options_form_submit to options_submit in order for the submit function to be executed.

The problem occurs using the dev version and 3.10.

I have made a patch that makes the change..

Comment	File	Size	Author
#3	views-views_handler_relationship_groupwise_max-2463053-3.patch	770 bytes	Andrew Answer
#3	7.x-3.x: PHP 7.1 & MySQL 5.5, D7 234 pass
#1	views-options_form_submit_to_options_submit-2463053-1.patch	763 bytes	prinds
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

prinds CreditAttribution: prinds commented 31 March 2015 at 15:35

Status:

Active

» Needs review

File	Size
views-options_form_submit_to_options_submit-2463053-1.patch	763 bytes

Comment #2

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented 16 January 2019 at 16:32

Status:	Needs review	» Needs work
Issue tags:		+Needs reroll

1 file was hidden/shown/deleted

File	Size
views-options_form_submit_to_options_submit-2463053-1.patch	763 bytes

The 4 year old patch to views_handler_relationship_groupwise_max.inc does not apply to the latest views 7.x-3.x-dev and if still relevant needs to be rerolled.

Checking patch handlers/views_handler_relationship_groupwise_max.inc...
error: while searching for:
  /**
   * When the form is submitted, take sure to clear the subquery string cache.
   */
  function options_form_submit(&$form, &$form_state) {
    $cid = 'views_relationship_groupwise_max:' . $this->view->name . ':' . $this->view->current_display . ':' . $this->options['id'];
    cache_clear_all($cid, 'cache_views_data');
  }

error: patch failed: handlers/views_handler_relationship_groupwise_max.inc:164
error: handlers/views_handler_relationship_groupwise_max.inc: patch does not apply