This might be a warning but it causes the update to fail for me. Having dug around it seems that any existing components using "NULL" for the "name" field will not allow the field structure to change with the db_change_field method.

I am in the process of writing a patch that does a query on the database to find any existing components that have "NULL" for the "name" field, changes them to be empty instead and continues the update as normal.

It would be good to hear some feedback on this!

CommentFileSizeAuthor
#1 webform-2462801-component_name_length_warning-2.patch788 bytescolinstillwell
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

colinstillwell’s picture

colinstillwell CreditAttribution: colinstillwell commented
FileSize
webform-2462801-component_name_length_warning-2.patch788 bytes
colinstillwell’s picture

colinstillwell CreditAttribution: colinstillwell commented
Status: Active » Needs review
colinstillwell’s picture

colinstillwell CreditAttribution: colinstillwell commented
colinstillwell’s picture

colinstillwell CreditAttribution: colinstillwell commented

Status: Needs review » Needs work

The last submitted patch, 1: webform-2462801-component_name_length_warning-2.patch, failed testing.

DanChadwick’s picture

DanChadwick CreditAttribution: DanChadwick commented

How did you component table get components with NULL names? That might be the better question.

Also, this update can be done with a single call to db_update().

DanChadwick’s picture

DanChadwick CreditAttribution: DanChadwick commented
Status: Needs work » Closed (works as designed)

I looked through the code and I don't see any history of allowing empty (much less NULL) component names. I'd say that your database was damaged. In this case, I don't see a need to modify the update.

If you can show that your database was subjected only to the recommended update path, please re-open. I'm pretty sure that if there was a common patch where NULL component names were allowed, we'd be inundated with reports long before now.