Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.This is to announce that I tested Sparkleshare with Drupal core.
Well, not really.
I tried it and it felt the need to announce it's presence by making a commit.
What a silly idea.
I have removed the "write to VCS" permission for myself.
If anybody knows how to make that commit go away, be my guest.
OP
"Embarrassing commit 3ae1b68"
nothing embarrassing about anything done by someone who is a 14 Drupal vet
/me bows
| Comment | File | Size | Author |
|---|
Comments
Comment #1
sidharrell CreditAttribution: sidharrell commentedComment #2
Wim LeersMarked #2462779: Revert commit 3ae1b68 as a duplicate.
Comment #3
Wim LeersIf we want this to be removed from history, we have to do it before any more commits to Drupal core are done. Raising priority to critical & marking RTBC to get committer attention.
Comment #4
sidharrell CreditAttribution: sidharrell commentedComment #5
dawehnerI think its not worth to rewrite the history. Having some reference to other free software in our git history is not dramatically horrible,
but yeah no question, its sad that it happened.
Comment #6
sidharrell CreditAttribution: sidharrell commentedComment #7
Wim Leers@dawehner: works for me :)
@sidharrell: @killes has been running much of the Drupal infrastructure for many, many years. That explains why he has git access. There's no security problem here :)
Comment #8
sidharrell CreditAttribution: sidharrell commentedyeah, I talked with him in #drupal
but when it gets committed, what do we want the commit log message to read?
Comment #9
sidharrell CreditAttribution: sidharrell commentedper IRC discussion. least you didn't say you disagreed.
Comment #10
xjmLet's not abuse the critical priority just for issue visibility, please.
The commit is going to be in the history one way or another, like every other silly accidental commit that has been made.
@sidharrell, the commit message will read "REVERT [...original message]" which is the default behavior for reverts in git. The issue title is not used and a patch is not needed. Thanks!
Comment #11
xjmComment #12
alexpottI just reverted the commit - I did not commit the patch attached to this issue. Also as history had moved on since the commit I don't think it is correct to rewrite it.
Committed 94af765 and pushed to 8.0.x. Thanks!
Comment #13
Wim LeersThat's why I said: . That's the only reason I made this critical. We chose not to rewrite history, hence criticalness indeed doesn't make sense anymore.
Comment #14
xjmWe should only use critical for things that block the release of Drupal 8. :) For time-sensitive things just pinging a committer is more effective anyway.
Comment #15
Wim LeersNo committer was online; this was the best way I could think of to signal them.
Comment #16
Fabianx CreditAttribution: Fabianx commentedThats a nitpick, but we can't / couldn't sensibly ship D8 with those sparkleshare files present :-D.
Comment #17
sidharrell CreditAttribution: sidharrell commentedsorry, guess I have the convert's zeal.
Drupal rules! woot!