I was having issues with my patch on https://www.drupal.org/node/2462417 and couldn't figure out why. Something's going on with mentions.module whenever I'm saving new lines of code to it, it seems to be generating trailing white spaces. This was originally on sublime - then I tried on vi, vim and still the same issue. Also on my windows machine.

The file format maybe corrupted? I've copied the whole file over to a new file in this patch.

CommentFileSizeAuthor
mentions-module-file-issue.patch32.67 KBjerrylow
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Deciphered’s picture

Deciphered CreditAttribution: Deciphered commented

How are you generating the patch? If you are using git diff you should be able to set git to ignore line endings. Google it.

If that doesn't work, let me know.

jerrylow’s picture

jerrylow CreditAttribution: jerrylow commented

Hey @Deciphered I have

git config --global core.autocrlf true

it definitely doesn't work for me. Its odd because the white spaces definitely doesn't show up on any other files in this repo/module except the .module file.

Deciphered’s picture

Deciphered CreditAttribution: Deciphered commented
Priority: Critical » Minor
Status: Needs review » Closed (cannot reproduce)

Can't reproduce this and it's far from critical.

Deciphered’s picture

Deciphered CreditAttribution: Deciphered commented
Status: Closed (cannot reproduce) » Fixed

I take it back, while I couldn't reproduce an issue making a patch, I can confirm that the line-endings where incorrect and they have been fixed now.

  • Deciphered committed f128657 on 7.x-1.x 
    #2462661 by Deciphered, jerrylow: Fixed line endings.

  • Deciphered committed f128657 on 7.x-2.x 
    #2462661 by Deciphered, jerrylow: Fixed line endings.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.