Similar to DS Extra Layouts, this module provides a number of new layouts for Display Suite, but all of these layouts are CSS3-based tabbed layouts that transform into accordion regions at a certain breakpoint. Future development includes further integration with Taxonomy, User, Entityform, Bean, Field Collection and other common non-node entities (almost strictly for tab label overrides as most of the remaining functionality should remain the same, regardless of the entity).

Please have a look at: https://www.drupal.org/sandbox/dshields/2460839

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/dshields/2460839.git ds_tabbed_layouts

Thanks

Comments

dshields’s picture

Issue summary: View changes
PA robot’s picture

Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxdshields2460839git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

dshields’s picture

Issue summary: View changes
dshields’s picture

Status: Needs work » Needs review

I've adjusted the git clone URL, which was the only reported error by the automatic test.

mgifford’s picture

Ran this though Coder. Some minor things:

@file block missing from container_height.js & next_prev.js - https://www.drupal.org/node/1354#files

In ds_tabbed_layouts.admin.inc & ds_tabbed_layouts.module - there's no problem with the $i variable that Coder is warning about. That's fine.

There are also some minor spacing isues in ds_tabbed_layouts.module:

severity: normalreview: style_string_spacingLine 183: String concatenation should be formatted with a space separating the operators (dot .) and the surrounding terms [style_string_spacing]

$markup = '<input id="tabbed-' . $tab . '-1" class="element-invisible" type="radio" name="tab-group" value="1" checked="checked" /><label for="tabbed-' . $tab . '-1" class="tabbed-tab" name="tab-group">' . t('@tab_name', array('@tab_name' => variable_get($variable))) . '</label>';

I'll get back with more later. First sweep looks fine.

dshields’s picture

Issue summary: View changes

Thanks for your feedback, mgifford!
I've addressed these issues in the latest commit.

andrefy’s picture

Thanks for your contributions, I took a look and didn't found any blockers but a couple of things that can be improved, I am not moving this to back to need work but also not moving this for RBC

Automated Review

FILE: ...t/sites/all/modules/sandbox/ds_tabbed_layouts/ds_tabbed_layouts.install
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
 2 | ERROR | Missing file doc comment
 3 | ERROR | Missing function doc comment
--------------------------------------------------------------------------------

FILE: ...ot/sites/all/modules/sandbox/ds_tabbed_layouts/ds_tabbed_layouts.module
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 347 | ERROR | Missing function doc comment

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.

This module has more than 120 code lines and 6 php functions.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
  1. (+) Release blocker
  2.           Drupal.behaviors.nextButton
            

    By best practice I would recoment to prefix this behavior with your module name, this way it will
    not get conflicts with other modules called nextButton.

  3.         function HOOK_uninstall(){
              // Delete created variables.
              variable_del('var');
            }
            

    Please remove all variables created by the ds_tabbed_layouts_install function

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

This review uses the Project Application Review Template.

darol100’s picture

Status: Needs review » Needs work

Moving this to "Needs Work" because of the Release blocker that comments #7 mention.

PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.