Similar to DS Extra Layouts, this module provides a number of new layouts for Display Suite, but all of these layouts are CSS3-based tabbed layouts that transform into accordion regions at a certain breakpoint. Future development includes further integration with Taxonomy, User, Entityform, Bean, Field Collection and other common non-node entities (almost strictly for tab label overrides as most of the remaining functionality should remain the same, regardless of the entity).
Please have a look at: https://www.drupal.org/sandbox/dshields/2460839
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/dshields/2460839.git ds_tabbed_layouts
Thanks
Comments
Comment #1
dshields CreditAttribution: dshields at OpenConcept Consulting Inc. commentedComment #2
PA robot CreditAttribution: PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxdshields2460839git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
dshields CreditAttribution: dshields at OpenConcept Consulting Inc. commentedComment #4
dshields CreditAttribution: dshields at OpenConcept Consulting Inc. commentedI've adjusted the git clone URL, which was the only reported error by the automatic test.
Comment #5
mgiffordRan this though Coder. Some minor things:
@file block missing from container_height.js & next_prev.js - https://www.drupal.org/node/1354#files
In ds_tabbed_layouts.admin.inc & ds_tabbed_layouts.module - there's no problem with the $i variable that Coder is warning about. That's fine.
There are also some minor spacing isues in ds_tabbed_layouts.module:
$markup = '<input id="tabbed-' . $tab . '-1" class="element-invisible" type="radio" name="tab-group" value="1" checked="checked" /><label for="tabbed-' . $tab . '-1" class="tabbed-tab" name="tab-group">' . t('@tab_name', array('@tab_name' => variable_get($variable))) . '</label>';
I'll get back with more later. First sweep looks fine.
Comment #6
dshields CreditAttribution: dshields at OpenConcept Consulting Inc. commentedThanks for your feedback, mgifford!
I've addressed these issues in the latest commit.
Comment #7
andrefy CreditAttribution: andrefy as a volunteer commentedThanks for your contributions, I took a look and didn't found any blockers but a couple of things that can be improved, I am not moving this to back to need work but also not moving this for RBC
Automated Review
Manual Review
This module has more than 120 code lines and 6 php functions.
By best practice I would recoment to prefix this behavior with your module name, this way it will
not get conflicts with other modules called nextButton.
Please remove all variables created by the ds_tabbed_layouts_install function
The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.
This review uses the Project Application Review Template.
Comment #8
darol100 CreditAttribution: darol100 as a volunteer and commentedMoving this to "Needs Work" because of the Release blocker that comments #7 mention.
Comment #9
PA robot CreditAttribution: PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.