Problem/Motivation

At the moment users are not able to create hierarchy through tabledrag tables because of the javascript functionality is broken and you cannot see which level current item has been set.

Proposed resolution

Fix it!

Remaining tasks

Fix it!
Test it!

User interface changes

API changes

CommentFileSizeAuthor
#3 tabledrag_hierarchy-2461823-3.patch697 byteslauriii
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii commented
Issue summary: View changes
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii commented

Seems to be broken after #2449445: Add "indentation" class back to indentation theme hook, use it for styling

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii commented
Status: Active » Needs review
FileSize
tabledrag_hierarchy-2461823-3.patch697 bytes
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii commented
Issue summary: View changes
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Issue tags: +JavaScript

For Drupal JS squad.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented

Ideally we would get rid of the indentation & js-indentation class and replace all .js-indentation with [data-drupal-indentation] as well as move all the relevant CSS from system.module.css to core/misc/tabledrag/tabledrag.css and move the JS file in this folder too (like for dropbutton).

The patch fixes the issue, but I'd like to take the opportunity to isolate all the tabledrag stuff where it belongs.

Bojhan’s picture

Bojhan CreditAttribution: Bojhan as a volunteer commented

@alexpott Mentioned that we should fix the core problem first. Fix the regression and then fix the larger issue.

I tested it and it works here.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Needs review » Closed (duplicate)
Related issues: +#2449445: Add "indentation" class back to indentation theme hook, use it for styling

This is a duplicate of #2449445: Add "indentation" class back to indentation theme hook, use it for styling