We have started seeing an issue where all content in some dialogs is pushed off the right of the screen.

The issue occurs for some nodes when using the EPSA Crop module. The Brightcove module css is applied to the dialog for some reason and the rules break the dialog contents. Note that this is not all nodes, other nodes behave fine and I have not been able to find out what the difference is.

You can see the broken dialog contents here;
Broken EPSA Crop Dialog

Here is Firebug inspecting the title, you can see I've highlighted the brightcove css.
Broken dialog from brightcove css

Lastly, another non-affected node with no brightcove css applied.
Non broken dialog with no brightcove css

We're happy to provide a patch to kill the 'line-height' of the css rule because thats the only bit that is broken but not sure about regression.

CommentFileSizeAuthor
#10 2458893-implementing-patch-for-7.x-5.1-version.patch1.26 KBdeepak_123
#4 brightcove-fix-dialog-css.patch595 byteszzzp
#2 brightcove-fix-dialog-css-2458893-3.patch1.05 KBCB
broken-dialog-firebug.png312.08 KBCB
broken-epsa-crop-dialog.png40.02 KBCB
non-broken-firebug.png232.06 KBCB
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

CB’s picture

CB
Location Sydney
CreditAttribution: CB commented

Just a quick update, the node that is broken here has a brightcove field in a paragraph while the other does not.

A quick and simple fix (initially at least) is to kill the line-height.

CB’s picture

CB
Location Sydney
CreditAttribution: CB commented
FileSize
brightcove-fix-dialog-css-2458893-3.patch1.05 KB

Basic patch attached. We needed to fix this ASAP so needed to just do a quick and dirty fix.

CB’s picture

CB
Location Sydney
CreditAttribution: CB commented
Status: Active » Needs review
zzzp’s picture

zzzp CreditAttribution: zzzp commented
Version: 7.x-5.1 » 7.x-6.x-dev
FileSize
brightcove-fix-dialog-css.patch595 bytes

I've spotted this behaviour too, it becomes apparent when using admin themes other than Seven, e.g. Adminimal.
I have rerolled the patch so it can apply to both 7.x-6.x-dev and 7.x.6.0-beta2 - hope that helps :)

sammarks15’s picture

sammarks15 CreditAttribution: sammarks15 at Able Engine commented
Status: Needs review » Reviewed & tested by the community

I can verify this patch worked for me when using the Adminimal theme. Moving to RTBC.

CB’s picture

CB
Location Sydney
CreditAttribution: CB commented

Yep, confirmed here using Seven.

  • Yorirou committed 234a120 on 7.x-6.x 
    Issue #2458893 by cbiggins, zzzp: Brightcove module css breaking jQuery...
tamasd’s picture

tamasd CreditAttribution: tamasd at Pronovix commented
Version: 7.x-6.x-dev » 7.x-6.0-rc1
Status: Reviewed & tested by the community » Fixed

Thanks for the patch

jan.mashat’s picture

jan.mashat CreditAttribution: jan.mashat at Pronovix for BrightCove commented
Status: Fixed » Closed (fixed)
deepak_123’s picture

deepak_123 CreditAttribution: deepak_123 commented
Title: Brightcove module css breaking jQuery UI dialogs » Brightcove module css breaking jQuery UI dialogs - fix for 7.x-5.1 version
Version: 7.x-6.0-rc1 » 7.x-5.1
Status: Closed (fixed) » Needs review
FileSize
2458893-implementing-patch-for-7.x-5.1-version.patch1.26 KB

I faced this issue with the version 7.x-5.1 of this module, hence pushing the patch for this version. Please merge.

deepak_123’s picture

deepak_123 CreditAttribution: deepak_123 commented
Title: Brightcove module css breaking jQuery UI dialogs - fix for 7.x-5.1 version » Brightcove module css breaking jQuery UI dialogs
jan.mashat’s picture

jan.mashat CreditAttribution: jan.mashat at Pronovix for BrightCove commented
Status: Needs review » Closed (won't fix)
Issue tags: +unsupported

This version of the module is no longer supported. Only the latest 2 major versions are supported, which are currently 8.x-1.x and 7.x-6.x. Therefore I'm tagging this issue as 'unsupported' and closing it (won't fix). If this feature is business critical for your organization, please contact your Brightcove account manager for further support.