The config DIFF used to have colors.

Proposed resolution

Bring back the colors

Remaining tasks

User interface changes

API changes


dawehner’s picture

So the class on the table is missing:

table.diff .diff-deletedline {
  background-color: #ffa;
  width: 50%;


<table class="responsive-enabled" data-striping="1">
                            <th colspan="2">Old</th>
                            <th colspan="2">New</th>
                      <tr class="odd">
                      <td class="diff-marker">-</td>
                      <td class="diff-context diff-deletedline">      enabled: <span class="diffchange">true</span></td>
                      <td class="diff-marker">+</td>
                      <td class="diff-context diff-addedline">      enabled: <span class="diffchange">false</span></td>
xjm’s picture

pjonckiere’s picture

Made a patch based on the instructions in #1. I'm not sure where that table's tests live though. Suggestions?

pjonckiere’s picture

Status: Active » Needs work
Issue tags: +Needs tests
aerozeppelin’s picture

Status: Needs work » Needs review
1.38 KB
1.38 KB

Added test to check presence of table with class 'diff'.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs tests
+++ b/core/modules/config/src/Tests/ConfigImportUITest.php
@@ -311,6 +311,10 @@ function testImportDiff() {
+    // Verify diff colors are displayed.
+    $result = $this->xpath('//table[contains(@class, :class)]', array(':class' => 'diff'));
+    $this->assertEqual(count($result), 1, "Diff UI is displaying colors.");


The last submitted patch, 3: diff_ui_is_missing_colors-2458775-3.patch, failed testing.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 64a866b and pushed to 8.0.x and 8.1.x. Thanks!

  • alexpott committed de2aab8 on 8.1.x
    Issue #2458775 by aerozeppelin, pjonckiere, dawehner: Diff UI is missing...

  • alexpott committed 64a866b on
    Issue #2458775 by aerozeppelin, pjonckiere, dawehner: Diff UI is missing...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.