Missing arguments for addressfield_default_values [#2458721]

addressfield 7.x-1.0 requires calling addressfield_default_values() with different parameters:

Warning : Missing argument 1 for addressfield_default_values(), called in XXX/commerce_paypal/modules/ec/commerce_paypal_ec.module on line 1386 and defined in addressfield_default_values() (line 375 in XXX/addressfield/addressfield.module).
Warning : Missing argument 2 for addressfield_default_values(), called in XXX/commerce_paypal/modules/ec/commerce_paypal_ec.module on line 1386 and defined in addressfield_default_values() (line 375 in XXX/addressfield/addressfield.module).
Notice : Undefined variable: field in addressfield_default_values() (line 376 in XXX/addressfield/addressfield.module).
Notice : Undefined variable: instance in addressfield_default_values() (line 376 in XXX/addressfield/addressfield.module).
Notice : Undefined variable: instance in addressfield_default_values() (line 377 in XXX/addressfield/addressfield.module).
Notice : Undefined variable: field in addressfield_default_values() (line 403 in XXX/addressfield/addressfield.module).
Notice : Undefined variable: instance in addressfield_default_values() (line 404 in XXX/addressfield/addressfield.module).

I'm marking this as related to PayPal EC but I see an equivalent bug in commerce_paypal_wps.module.

See related issues for similar problems with other modules that call this function.

Comment	File	Size	Author
#16	2458721-paypal-addressfield-defaults-16.patch	1.97 KB	torgosPizza
#16
#1	commerce_paypal-addressfield-default-values-2458721-1.patch	1.85 KB	mvc
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

mvc

they

English

Montréal, CA

CreditAttribution: mvc commented 24 March 2015 at 20:43

Status:

Active

» Needs review

File	Size
commerce_paypal-addressfield-default-values-2458721-1.patch	1.85 KB

Patch that works for me with commerce_paypal 7.x-2.3 and addressfield 7.x-1.0, using PayPal EC. I didn't test with PayPal WPS but it will probably work for that too.

Comment #2

mvc

they

English

Montréal, CA

CreditAttribution: mvc commented 24 March 2015 at 20:45

Comment #3

ytsurk

Switzerland

CreditAttribution: ytsurk commented 23 April 2015 at 16:41

looks good to me (all issues use same approach) and works :D

thx

Comment #4

howdytom CreditAttribution: howdytom commented 29 April 2015 at 08:50

#1 worked like a charm on
commerce_paypal_ec.module and commerce_paypal_wps.module

Thank you!

Comment #5

mvc

they

English

Montréal, CA

CreditAttribution: mvc commented 30 April 2015 at 10:39

ytsurk, howdytom: if this patch seems correct & works for you please change the status to "reviewed & tested by the community" so that the maintainer knows it's ready to be commited. etiquette here on drupal.org requires that i not do this myself :)

Comment #6

howdytom CreditAttribution: howdytom commented 30 April 2015 at 10:45

Status:

Needs review

» Reviewed & tested by the community

Comment #7

JustDrup CreditAttribution: JustDrup commented 16 May 2015 at 14:10

It worked for me too. I used it for PayPal EC.
thank you very much

if this patch seems correct & works for you please change the status to "reviewed & tested by the community"

I dont´t know how do it.

Comment #8

mvc

they

English

Montréal, CA

CreditAttribution: mvc commented 22 May 2015 at 02:46

JustDrup: you just change the "status" field right below this comment :) but don't worry, you can see that the current status was already changed.

documentation for the issue submission/edit form is here: https://www.drupal.org/node/314328
a description of issue queue statuses is here: https://www.drupal.org/issue-queue/status

Comment #9

ProjetWeb CreditAttribution: ProjetWeb as a volunteer commented 20 June 2015 at 15:32

I have the same probleme, but i am not familiar with git... How can i patch directly in commerce_paypal_ec.module?

Thank you in advance for your help

Comment #10

mvc

they

English

Montréal, CA

CreditAttribution: mvc commented 2 July 2015 at 17:21

@ProjetWeb : documentation for working with patches is available at https://www.drupal.org/patch and instructions for applying patches are at https://www.drupal.org/patch/apply

since this patch is small, you could also do it by hand. look at https://www.drupal.org/files/issues/commerce_paypal-addressfield-default... and remove the lines starting with - and add the lines starting with +

Comment #11

jantoine CreditAttribution: jantoine commented 10 July 2015 at 16:09

@mvc,

Thanks for the patch! Confirmed this fixes the address errors for both billing and shipping with Express Checkout.

Comment #12

onejam CreditAttribution: onejam commented 23 July 2015 at 02:09

I confirm the patch fixed the issue as well, thanks.

Comment #13

a.milkovsky

he/him

UTC +2

CreditAttribution: a.milkovsky as a volunteer commented 12 August 2015 at 20:01

+1 for patch #1. works for me. Is it planned to be committed?

Comment #14

Sam Moore

he/him

Sandy Hook, CT

CreditAttribution: Sam Moore as a volunteer commented 24 August 2015 at 02:43

Confirmed patch in #1 works for me.

Comment #15

chrisolof CreditAttribution: chrisolof commented 27 September 2015 at 04:24

Patch in #1 appears to work and errors are gone.

Comment #16

torgosPizza

he/him

English

Portland, OR

CreditAttribution: torgosPizza commented 21 October 2015 at 16:04

Status:	Reviewed & tested by the community	» Needs review
Issue tags:		+commerce-sprint

File	Size
2458721-paypal-addressfield-defaults-16.patch	1.97 KB

Patch no longer applies to -dev, so here is a re-roll.

Comment #17

fizk CreditAttribution: fizk commented 6 November 2015 at 02:21

Status:

Needs review

» Reviewed & tested by the community

This needs to be committed. The patch is already being used by Commerce Kickstart.

@rszrama It seems odd that the patch was included in Commerce Kickstart instead of being committed... Is there anything to that?

Comment #18

mglaman

English

WI, USA

CreditAttribution: mglaman at Centarro commented 9 November 2015 at 22:35

fizk, I currently maintain CK2 and there was a patch to include this patch. Most often profiles do this. We'd have included that patch anways until a release was made.

Comment #19

fizk CreditAttribution: fizk commented 10 November 2015 at 03:11

@mglaman Thanks, but why not just commit this patch into commerce_paypal, since rszrama, maintainer of this project, is part of Commerce Guys and also commits to Commerce Kickstart?

Comment #20

torgosPizza

he/him

English

Portland, OR

CreditAttribution: torgosPizza commented 10 November 2015 at 04:15

Yeah I don't really see a reason not to apply this to -dev. It's pretty well tested, and a minor change to bring the module into line with current requirements of Addressfield. I don't use CK - Ryan and Josh had actually advised against that after we had already started our RiffTrax D6->7 Upgrade, resulting in a restart and lots of lost time - so I would highly highly recommend committing this to 7.x-2.x-dev.

Comment #21

10 November 2015 at 21:38

rszrama committed 5f12628 on 7.x-2.x authored by torgosPizza

Issue #2458721 by mvc, torgosPizza: add missing arguments to calls to...

Comment #22

rszrama CreditAttribution: rszrama at Centarro commented 10 November 2015 at 21:39

Status:

Reviewed & tested by the community

» Fixed

Thanks everyone! Sorry it took a while, but I've just committed this. It's available in -dev and will be in the next release.

Comment #23

24 November 2015 at 21:44

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #24

Stone Liu CreditAttribution: Stone Liu commented 1 December 2015 at 04:12

Thanks for the patch and there is an imperfection to it:

If the order's shipping address is different to the billing address this patch simply collects the shipping address at the EC transaction page as "billing information", resulting in one has to change it back to the correct billing info manually.

Wondering someone run into this as well? This patch solve the error message well but caused additional correcting/filling work on the part of shoppers. It will be perfect if this could be fixed as well. :)