Compatibility issues with LabJS [#2458603]

I have not yet looked into this thoroughly, but MNC seems to have a compatibility issue with the LabJS asynchronous javascript loader.

Specifically, I'm seeing:

Uncaught TypeError: Cannot read property 'qtip_classes' of undefined

Which relates to mnc.js line 234:

classes: Drupal.settings.mnc.qtip_classes + ' qtip-view',

So we have Drupal.settings.mnc not yet defined, even though LabJS makes sure that settings is loaded before asynchronously loading the rest of the scripts. With all the js I have on my site (which is quite a bit), only mnc is suffering from this issue (see screenshot from New Relic: http://i.imgur.com/693kp77.png ).

Any thoughts?

Comments

Comment #1

Andre-B

German

Offenburg, Germany

CreditAttribution: Andre-B commented 24 March 2015 at 17:44

since I am not initializing qtip() in mnc it must be done in qtip itself e.g. after page load, sounds like a race condition. (I am remember fixing ordering of jsfiles for a different site, but it's too long ago)

Comment #2

Andre-B

German

Offenburg, Germany

CreditAttribution: Andre-B commented 24 March 2015 at 17:49

at least for the js, css and libraries introduced by mnc you can change everything the module does from the outside:

drupal_alter('mnc_js', $js);
    foreach ($js as $arguments) {
      call_user_func_array('drupal_add_js', $arguments);
    }

    drupal_alter('mnc_css', $css);
    foreach ($css as $arguments) {
      call_user_func_array('drupal_add_css', $arguments);
    }

    drupal_alter('mnc_libraries', $libraries);
    foreach ($libraries as $arguments) {
      call_user_func_array('drupal_add_library', $arguments);
    }