No longer possible to test Drupal 6 core and contrib modules [#2457565]

From https://qa.drupal.org/pifr/test/1004873

[01:17:37] Applying in /var/lib/drupaltestbot/sites/default/files/checkout file=/var/lib/drupaltestbot/sites/all/modules/project_issue_file_review/review/simpletest/D6-core-simpletest.patch
[01:17:37] Command [git apply --check -p1 /var/lib/drupaltestbot/sites/all/modules/project_issue_file_review/review/simpletest/D6-core-simpletest.patch 2>&1] failed
  Duration 0 seconds
  Directory [/var/lib/drupaltestbot/sites/default/files/checkout]
  Status [1]
 Output: [error: patch failed: includes/bootstrap.inc:1442
error: includes/bootstrap.inc: patch does not apply].
[01:17:37] Encountered error on [review], details:
array (
  '@filename' => 'D6-core-simpletest.patch',
)
[01:17:37] Review complete. test_id=1004873 result code=8 details=Array
(
    [@filename] => D6-core-simpletest.patch
)

Comments

Comment #1

webchick

she/they

English

Vancouver 🇨🇦

CreditAttribution: webchick at Acquia commented 23 March 2015 at 16:10

Title:	Drupal 6 core patch does not apply anymore	» No longer possible to test Drupal 6 core
Priority:	Major	» Critical

According to Gábor, bootstrap.inc changed slightly in the Drupal 6 release that went out on Wednesday. As a result, the patch needed to enable testing on Drupal 6 core no longer applies.

This is holding up future Drupal 6 core releases, as well as work on localize.drupal.org.

Comment #2

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy at Acquia commented 23 March 2015 at 16:13

Title:

No longer possible to test Drupal 6 core

» No longer possible to test Drupal 6 core and contrib modules

Well, its more like D6 contrib is blocked, that is sooner than a D6 release itself.

Comment #3

jthorson CreditAttribution: jthorson commented 23 March 2015 at 18:28

Should be an easy fix ... we need a re-roll of http://cgit.drupalcode.org/project_issue_file_review/tree/review/simplet...

Novice, anyone?

Comment #4

Mixologic

He/Him/His

English

Portland, OR

CreditAttribution: Mixologic at Drupal Association commented 23 March 2015 at 19:50

Rerolled and pushed. Can somebody please re-attempt a d6 test? I dont have anything handy.

http://cgit.drupalcode.org/project_issue_file_review/commit/?id=1699fe5c...

Comment #5

Mixologic

He/Him/His

English

Portland, OR

CreditAttribution: Mixologic at Drupal Association commented 23 March 2015 at 21:36

Status:

Active

» Needs review

Comment #6

webchick

she/they

English

Vancouver 🇨🇦

CreditAttribution: webchick at Acquia commented 23 March 2015 at 21:56

Ooh, based on https://qa.drupal.org/pifr/test/27318 it looks like this might be fixed! Probably should wait on Gábor to confirm.

Thanks so much for the speedy turnaround!

Comment #7

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy at Acquia commented 24 March 2015 at 07:28

https://qa.drupal.org/pifr/test/1004873 was my patch test result that I posted as a link at the start of the issue summary. Sending for a retest now. Will close when/if comes back with a result.

Comment #8

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy at Acquia commented 24 March 2015 at 07:34

Status:

Needs review

» Needs work

https://qa.drupal.org/pifr/test/1004873 failed the same way just now, so not yet resolved on testbot.

Last tested	Tue, 03/24/2015 - 08:30:36

[00:30:36] Applying in /var/lib/drupaltestbot/sites/default/files/checkout file=/var/lib/drupaltestbot/sites/all/modules/project_issue_file_review/review/simpletest/D6-core-simpletest.patch
[00:30:36] Command [git apply --check -p1 /var/lib/drupaltestbot/sites/all/modules/project_issue_file_review/review/simpletest/D6-core-simpletest.patch 2>&1] failed
  Duration 0 seconds
  Directory [/var/lib/drupaltestbot/sites/default/files/checkout]
  Status [1]
 Output: [error: patch failed: includes/bootstrap.inc:1442
error: includes/bootstrap.inc: patch does not apply].
[00:30:36] Encountered error on [review], details:
array (
  '@filename' => 'D6-core-simpletest.patch',
)

Comment #9

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy at Acquia commented 24 March 2015 at 07:36

BTW the link @webchick posted is Last tested Tue, 03/10/2015 - 14:07:51 so not indicative of this being fixed either. (I did not commit to the module because there is no test result that could convince me I'm not breaking the module). So cannot roll out the fix I am working on to localize.drupal.org.