Ads with end date in the past are republished by cron (show_todate field does not exist in node_load) [#2455595]

When an ad with a start and end date is expired (unpublished) via cron, it as republished, even though the current date is greater than the end date, and the ad should therefore remain unpublished.

What happens is that node_save() which is triggered by cron (with the correct value set for $node->status = 0) invokes the node_presave() hook which runs simpleads_node_presave() - this checks for a form field $node->field_ad_date[$node->language][0]['show_todate'] which doesn't exist when a node is loaded via node_load. So because this value does not exist, the module presumes there is no end date and sets the status to published.

I am working on a fix.

Comment	File	Size	Author
#3	simpleads-end_date-2455595-3.patch	456 bytes	skorzh
#3	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 No tests found
#2	simpleads-test_for_end_date-2455595-2.patch	1.4 KB	foxtrotcharlie
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

foxtrotcharlie CreditAttribution: foxtrotcharlie commented 19 March 2015 at 15:10

Title:

Ads with end date in the past are republished by cron (show_todate field does not exist in node_load

» Ads with end date in the past are republished by cron (show_todate field does not exist in node_load)

Comment #2

foxtrotcharlie CreditAttribution: foxtrotcharlie commented 19 March 2015 at 19:11

Status:

Active

» Needs review

File	Size
simpleads-test_for_end_date-2455595-2.patch	1.4 KB

This patch finds another way to test whether or not an end date has been explicitly set.

When an ad is initially created, and the end date checkbox is left unchecked, when saved, the end date is set to the same value as the start date, so we can use this to test whether or not an end date was chosen. If they are the same, then we assume no end date was chosen, which we can then use to determine whether or not to continue publishing the ad.