Problem/Motivation

After creating a newsletter issue, the body of the issue is not visible in the node detail page. see screens attached.

Proposed resolution

Make the body available and add test coverage.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#6 newsletter_issue_body-2455471-6-interdiff.txt1.33 KBmbovan
#6 newsletter_issue_body-2455471-6.patch2.19 KBmbovan
#6 newsletter_issue_body-2455471-6-TEST-ONLY.patch1.33 KBmbovan
#3 simplenews_entity_view_default_body.png144.46 KBmbovan
#3 newsletter_issue_body-2455471-3.patch886 bytesmbovan
Screen Shot 2015-03-19 at 13.34.11.png18.42 KBAnushka-mp
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Anushka-mp’s picture

Anushka-mp CreditAttribution: Anushka-mp at MD Systems GmbH commented
Issue summary: View changes
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

Should be trivial, fix it manually and export the view_display config entity.

mbovan’s picture

mbovan CreditAttribution: mbovan at MD Systems GmbH commented
Status: Active » Needs review
FileSize
newsletter_issue_body-2455471-3.patch886 bytes
simplenews_entity_view_default_body.png144.46 KB

Fixed and exported core.entity_view_display.node.simplenews_issue.default.yml. Screenshot below.

Simplenews - entity view default display

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Issue tags: +Needs tests

Looks fine. Would be nice to extend the test coverage a bit to make sure this works.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Needs work
mbovan’s picture

mbovan CreditAttribution: mbovan at MD Systems GmbH commented
Status: Needs work » Needs review
Issue tags: -Needs tests
FileSize
newsletter_issue_body-2455471-6-TEST-ONLY.patch1.33 KB
newsletter_issue_body-2455471-6.patch2.19 KB
newsletter_issue_body-2455471-6-interdiff.txt1.33 KB

Added tests, removing the tag.

The last submitted patch, 6: newsletter_issue_body-2455471-6-TEST-ONLY.patch, failed testing.

giancarlosotelo’s picture

giancarlosotelo CreditAttribution: giancarlosotelo at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community

Looks fine.

The last submitted patch, 6: newsletter_issue_body-2455471-6-TEST-ONLY.patch, failed testing.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Reviewed & tested by the community » Fixed

Nice!

  • Berdir committed 08774d3 on 8.x-1.x authored by mbovan 
    Issue #2455471 by mbovan: Fixed Newsletter issue body is not visible

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.