Change record: https://www.drupal.org/node/2270941

CommentFileSizeAuthor
#3 xmlsitemap-watchdog_is_now_logging-2455217-3.patch7.22 KBcamoa
#1 xmlsitemap-watchdog-2455217-1.patch1.78 KBMichelle
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Michelle’s picture

Michelle
she/her
Primary language English
Location Wisconsin, USA
CreditAttribution: Michelle at Mediacurrent commented
Status: Active » Needs review
FileSize
xmlsitemap-watchdog-2455217-1.patch1.78 KB

A couple caveats:

1) I was not able to test this change because I kept running into other errors while trying to run it a second time. Rather than just sit on the fix, I decided to make a patch of it and will comment when I am able to test it (unless someone beats me to it).

2) There are watchdog references in the tests and in the submodules that I have not addressed in this patch.

tadityar’s picture

tadityar CreditAttribution: tadityar commented
Status: Needs review » Needs work

Thank you for noticing and working on this!

After searching for "watchdog(" I found other occurrences of the function. Might want to change them all in this issue, so I'm setting this to Needs Work.

camoa’s picture

camoa CreditAttribution: camoa at Camo Advanced Tech commented
Status: Needs work » Needs review
FileSize
xmlsitemap-watchdog_is_now_logging-2455217-3.patch7.22 KB

Did a quick replacement of the watchdog calls, needs testing.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Needs review » Reviewed & tested by the community

still applies, and looks good.

  • Dave Reid committed 3cd5f4f on 8.x-1.x authored by camoa 
    Issue #2455217 by Michelle, camoa: Updated watchdog() calls to use...
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid at Lullabot commented
Status: Reviewed & tested by the community » Fixed

Committed #1 to 8.x-1.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.