Field comment_field_data.field_name should be using Field API formatter

ding ding

are we sure there's no more usage?

+++ b/core/modules/comment/tests/modules/comment_test_views/test_views/views.view.test_comment_field_name.yml
@@ -0,0 +1,140 @@
+uuid: 8170fc88-d583-473e-8d00-d55e17710652

Suppose to be removed

fixes #5

+++ b/core/modules/comment/src/Tests/Views/CommentFieldNameTest.php
@@ -0,0 +1,36 @@
+class CommentFieldNameTest extends CommentTestBase {

Meh, can't we avoid adding web tests

+++ b/core/modules/comment/src/CommentViewsData.php
@@ -162,7 +162,8 @@ public function getViewsData() {
       'title' => t('Comment field name'),
       'help' => t('The Field name from which the comment originated.'),
       'field' => array(
-        'id' => 'standard',
+        'id' => 'field',
+        'field_name' => 'field_name',
       ),
       'filter' => array(
         'id' => 'string',

You should be able to get rid of the entire code block. Also 'field_name' here is afaik not needed. ... The entire field should be autogenerated

Fixes #7.2
For 7.1 do you have an example you could point me at?
Note this is Drupal\comment\Tests\View\CommentTestBase not Drupal\comment\Tests\CommentTestBase, but yeah still eventually winds back to WebTestBase via ViewsTestBase.

Well, there is ViewUnitTestBase you can use

The issue probably holds #2456705: Comment views field handlers need to be replaced with field/entity aware handlers

@dawehner we can't use ViewUnitTestBase because we need comment module installed.

I found no way to test render of the field because $view->field is empty

+++ b/core/modules/comment/src/Tests/Views/CommentFieldNameTest.php
@@ -0,0 +1,68 @@
+    $this->assertEqual($this->customComment->id(), $view->result[1]->cid, 'Result contains the comment cid.');
+    $this->assertEqual($this->fieldName, $view->result[1]->comment_field_data_field_name, 'Result contains the comment field name.');

You could use assertIdenticalResultSet here.

here it is

This looks alright now.

Discussed with @dawehner at IRC and discovered that better to extend a test with render to check access, so extended the test

The right service to use is account switcher

This is looking great!

There are no usecases for that field yet.

This issue addresses a critical bug and is allowed per https://www.drupal.org/core/beta-changes. Committed c7fd064 and pushed to 8.0.x. Thanks!