Problem/Motivation

When using views caching, the results and output is cached without considering the date pager.

Proposed resolution

See attached patch, by adding the pager value to the build_info, we can make sure that views is cached differently for different months, for example.

Note: This currently only works for the results cache, the output cache is cached based on the results, so if you're testing without having something to show in the calendar, then it will be cached incorrectly, see #2454671: Include build info in output cache for that.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#8 date-pager-cache-2454667-6.patch607 bytesBerdir
#6 date-pager-cache-2454667-1.patch1019 bytesBerdir
#4 date-pager-cache-2454667-1.patch1019 bytesBerdir
#1 date-pager-cache-2454667-1.patch0 bytesBerdir
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Issue summary: View changes
Status: Active » Needs review
FileSize
date-pager-cache-2454667-1.patch0 bytes
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

Patch looks pretty straightforward, if not even trivial.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 at Capgemini commented

@Berdir, hope you are testing the testbot with 0 bytes patch :)

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
FileSize
date-pager-cache-2454667-1.patch1019 bytes

Grml, yeah, yeah, you're all soo funny :p

Status: Needs review » Needs work

The last submitted patch, 4: date-pager-cache-2454667-1.patch, failed testing.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
date-pager-cache-2454667-1.patch1019 bytes

And another attempt.

Status: Needs review » Needs work

The last submitted patch, 6: date-pager-cache-2454667-1.patch, failed testing.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
FileSize
date-pager-cache-2454667-6.patch607 bytes

I think I should just go home.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs work » Needs review
Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews commented

The 4 year old patch to date_views_plugin_pager.inc in #8 still applies cleanly to the latest 7.x-2.x-dev and seems like a reasonable/necessary fix to me.