YouTube JavaScript Player API Deprecated

Thanks for bringing this up.

Attached are patches that remove the JS API option from the configuration settings in both the 7.x-1.x branch and 8.x-1.x branch.

It would be greatly appreciated if someone would apply these patches and test to ensure the rest of the configuration continues working as desired. They are pretty simple patches so I don't anticipate any negative side effects. Marking as "Needs review".

Thanks again!

Actually, after looking at the YouTube Embedded Players and Player Parameters, this option seems to still control the use of the IFrame API. We should probably leave the option in, but change the wording to make that clear.

I've committed fixes for this to both the 7.x-1.x and 8.x-1.x branches. As previously mentioned, the enablejsapi option/parameter still enables use of the IFrame API, so I left the option, renamed it to IFrame API, and updated the link in the setting to the IFrame API documentation. Thanks again for bringing this up!

@guschilds, be careful that strings run through t() don't end up with line breaks in them, otherwise those line-breaks will cause problems with translations.

There are several instances in this commit of strings in t() (usually form item descriptions) getting line-breaks added at the 80 character mark. Maybe your editor needs a Drupal plugin? :)

Reopening for a follow-up commit.

edit: it looks like the text #markup element could use that fix too! (that one was likely my fault)

Thanks for pointing this out @jenlampton. I went ahead and created #2924794: Remove line breaks within t() strings to address it since it involves code outside of this issue and I didn't see a follow up commit. Going to close this back up.