The node type settings property is still being cleanup in node_modules_uninstalled() - this is now all done through ConfigEntityBase / ThirdPartySettingsInterface so this is just dead code.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because it is dead code that we shouldn't be maintaining
Disruption None whatsoever
Files: 
CommentFileSizeAuthor
#6 d8.node-type-clean-up.patch994 bytesmgifford
d8.node-type-clean-up.patch994 bytesalexpott
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 97,007 pass(es). View

Comments

darol100’s picture

Status: Needs review » Reviewed & tested by the community

I have test this patch out and everything seem to be working fine.

1+ to be commit it.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, d8.node-type-clean-up.patch, failed testing.

Status: Needs work » Needs review

alexpott queued d8.node-type-clean-up.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, d8.node-type-clean-up.patch, failed testing.

Status: Needs work » Needs review

isntall queued d8.node-type-clean-up.patch for re-testing.

mgifford’s picture

Just re-uploading the patch for the bots.

swentel’s picture

Status: Needs review » Reviewed & tested by the community

Yeah, this can be removed.

alexpott’s picture

Version: 8.0.x-dev » 8.1.x-dev

Yep this is dead code but as the node.type:settings no longer exists this code is doing nothing. Therefore I think we should only commit this only to 8.1.x.

alexpott’s picture

The ability of third party settings to be fixed during a module uninstall is tested in \Drupal\system\Tests\Module\UninstallTest::testUninstallPage(). And in fact it uses node types to test this.

  • catch committed fd16d6e on 8.1.x
    Issue #2454057 by alexpott, mgifford: Node type settings property does...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.1.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.