Good Afternoon,

After using radix as a base theme for a project I've noticed that when using panelizer as part of the view mode of an entity (as opposed to full page override) that we end up loosing integration with contextual. Both the quickedit and contextual modules rely on the class contextual-links-region which are passed into relevent preprocess functions however the preprocess in panels.inc resets the array adding 2 values of its own.

CommentFileSizeAuthor
#4 reset_of_panelizer_view-2454051-4.patch675 bytesshadcn
#2 radix-prevent-preprocess-reset_2454051_2.patch734 bytesdan.munn
#1 radix-prevent-preprocess-reset_2454051.patch893 bytesdan.munn
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dan.munn’s picture

dan.munn CreditAttribution: dan.munn commented
Version: 7.x-3.0-rc2 » 7.x-3.x-dev
Status: Active » Needs review
FileSize
radix-prevent-preprocess-reset_2454051.patch893 bytes
dan.munn’s picture

dan.munn CreditAttribution: dan.munn commented
FileSize
radix-prevent-preprocess-reset_2454051_2.patch734 bytes

In hindsight this may not work either (patch proposed) - I'm not all that in favor of a theme duplicating work that modules should be themselves doing, so removing the hook looks more optimal.

Patch attached with radix_preprocess_panelizer_view_mode() removed.

steveoriol’s picture

steveoriol
Location Grenoble 🇫🇷
CreditAttribution: steveoriol commented

I get some notices about Undefined indexs of #entity_type and #bundle in radix_preprocess_panelizer_view_mode()
so, I try to remove also this hook...

shadcn’s picture

shadcn CreditAttribution: shadcn at Chapter Three commented
Assigned: Unassigned » shadcn
FileSize
reset_of_panelizer_view-2454051-4.patch675 bytes

Not sure why I'm seeing this issue just now. @steveoriol thanks for the ping on this.

It looks like panelizer are now adding the proper classes, so we could do without this preprocess. I'm adding a patch here that keeps the view mode class only for BC.

Let's review.