Hi,

with the addition of the MiniMap feature on March 8, I started to see this JavaScript error:

Error: TypeError: L.Control.MiniMap is undefined

this is added in ip_geoloc/js/ip_geoloc_leaflet_controls.js and if I comment

/*L.extend(L.Control.MiniMap.prototype, {
	hideText: Drupal.t('Hide this inset'),
	showText: Drupal.t('Show map inset'),
});*/

the error is gone. I don't intend to use the minimap, so I don't want to load another library just for an error to go away, so there should probably be a check to see if the minimap is active and the library is loaded before trying to extend the controls.

I also think this error prevented the leaflet_markecluster to load, so I spent some time to figure that out, looking in the wrong direction first. As soon as the error was gone, markercluster loaded as before.

Comments

RdeBoer’s picture

Assigned: Unassigned » RdeBoer
Status: Active » Fixed

Hi heliogabal,

Thank you for living dangerously at the cutting edge of new developments in IPGV&M!

I found the same thing earlier today, but forgot to check in the fix.

Sorry you wasted time. But thanks very much for reporting!

Try the latest check-in of IPGV&M 7.x-1.x-dev.

Rik

  • RdeBoer committed c465c27 on 7.x-1.x
    Fix for mini-map inset when not requested [#2453773]
    
heliogabal’s picture

Hi Rik,

yeah, I'm adventurous ;-) thanks for fixing it, and in general for your excellent work with this module. I simply wouldn't be able as a mere sitebuilder to provide such stunning, full-featured maps with all the niceties provided. And it mostly just works, even at the cutting edge, given some minor things like this, that I consider quite normal. Hope I could at least help in reporting it.

RdeBoer’s picture

Pleasure. Thanks for your support helio. It means a lot to me.
Rik

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.