Problem/Motivation

Config handler form in Views UI are currently missing their 'select all' behaviour, the JS in views-admin.js that is meant to be doing this does not work.

Proposed resolution

Fix the selectors and the JS. Form Ids Are now running through html ID I think, so e.g. what before was always 'views-ui-config-item-form', can now easily be 'views-ui-config-item-form--4' etc..

So let's add a 'views-ui-config-item-form' class to the form too, and use that. That's better than relying on any form ID or selector like 'form[id^=.views-ui-config-item-form]' or something.

It's also better to use the change event instead of click, so the checked property is always correct, and we should use prop() instead of attr().

With these fixes all is good again.

Remaining tasks

Review, manually test

User interface changes

Fix select all, it will appear again

API changes

N/A

CommentFileSizeAuthor
#28 Screen Shot 2020-10-01 at 9.44.52 AM.png109.63 KBrajneeshb
#16 config_handler_select-2452321-16.patch3.71 KBMac_Weber
#10 Content__Content____Site-Install.png35.15 KBdamiankloip
#10 interdiff-2452321-10.patch806 bytesdamiankloip
#10 2452321-10.patch3.17 KBdamiankloip
#7 Content__Content____Site-Install.png34.95 KBdamiankloip
#7 interdiff-2452321-7.patch994 bytesdamiankloip
#7 2452321-7.patch3.2 KBdamiankloip
d8-views-ui-select-all.patch2.23 KBdamiankloip
Content__Content____Site-Install.png54.09 KBdamiankloip
Content__Content____Site-Install.png48.1 KBdamiankloip
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Issue summary: View changes
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +VDC

Manually tested before and after and its great that the select all checkbox is there again.

The issue summary feels like being enriched with gems

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Needs review
Issue tags: +Needs usability review

For some reason this select all thing kind a weirds me out - what happens if you have a bundle named "select" - i know that would be an odd name but anything is possible.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented

Hmm, ok. It feels like that should be discussed in another issue though, as this is just fixing a bug?

Bojhan’s picture

Bojhan CreditAttribution: Bojhan commented
Issue tags: -Needs usability review

@damiankloip This could be solved by simply putting an small indent on the content types.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented

Thanks Bohjan, that seems pretty reasonable.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Issue summary: View changes
FileSize
2452321-7.patch3.2 KB
interdiff-2452321-7.patch994 bytes
Content__Content____Site-Install.png34.95 KB

Ok, here is an updated patch. I realised there was broken CSS we had before creating a border around these options too. So how about this?

Bojhan’s picture

Bojhan CreditAttribution: Bojhan commented

Awesome, lose the borders :P

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented

@Bojhan so it should look like this...

Or should or should the inner line remain and the indentation?

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
FileSize
2452321-10.patch3.17 KB
interdiff-2452321-10.patch806 bytes
Content__Content____Site-Install.png35.15 KB

ok, all borders removed now.

Current status:

Status: Needs review » Needs work

The last submitted patch, 10: interdiff-2452321-10.patch, failed testing.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Status: Needs work » Needs review

Sorry. Poorly named interdiff file.

Bojhan’s picture

Bojhan CreditAttribution: Bojhan commented

(Y)

NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde commented
Status: Needs review » Reviewed & tested by the community

Works as far as I can see perfectly and is in my list of auto apply before starting a new D8 project because not having a select all checkbox is very annoying.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Needs a reroll...

git ac https://www.drupal.org/files/issues/2452321-10.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3246  100  3246    0     0   3601      0 --:--:-- --:--:-- --:--:--  3684
error: patch failed: core/modules/views_ui/js/views-admin.js:769
error: core/modules/views_ui/js/views-admin.js: patch does not apply
Mac_Weber’s picture

Mac_Weber CreditAttribution: Mac_Weber as a volunteer commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
config_handler_select-2452321-16.patch3.71 KB

rerolled

damiankloip queued 16: config_handler_select-2452321-16.patch for re-testing.

damiankloip queued 16: config_handler_select-2452321-16.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 16: config_handler_select-2452321-16.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

rajneeshb’s picture

rajneeshb CreditAttribution: rajneeshb as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
Status: Needs work » Closed (cannot reproduce)
FileSize
Screen Shot 2020-10-01 at 9.44.52 AM.png109.63 KB

It's working fine on 8.9.x.