User's contact setting reverts to default when saving

You certainly should be able to unsubscribe from all mailing lists. I'll see if I can figure anything out.

I deleted your subscription manually from MailChimp's admin. I can unsubscribe myself via my Drupal.org profile. And you were still listed as subscribed despite unsubscribing via a link in email a few weeks ago. Unless others have this issue, I'm thinking this could be some quirk in MailChimp.

If I run user_save(user_load(26979)), that checks Personal contact form. We occasionally do that to pro-actively bakery sync. This seems like a potential Drupal core issue.

Yep, this looks like it is too aggressively reverts to the default:

function contact_user_presave(&$edit, $account, $category) {
  $edit['data']['contact'] = isset($edit['contact']) ? $edit['contact'] : variable_get('contact_default_status', 1);
}

Setting to major since this isa data loss bug that allows unwanted email to be sent.

Here is a quick patch. Still needs testing for new user creation. And probably needs tests.

My reading of the D8 code makes this look fixed in D8.

Here are some tests.

The test-only patch failed where expected. Let's try this for the full patch.

Rewrote this to use the old category system.

Of course, $this->contact_user in the test will be a stale object. Adding in

$this->contact_user = user_load($this->contact_user, TRUE);

so that it can be cleanly be saved.

I'm sticking with checking $category in the module, that's the most authentic Drupal 7 way.

… that should be

$this->contact_user = user_load($this->contact_user->uid, TRUE);

Another try without overwriting $this->contact_user.

Going back to my original patch from #5, with the working tests in #21.

My approach in #12 had failed because the default value for $category is 'account'. I think this approach is solid.

Looking good to me.

Committed to 7.x - thanks!

I think this was tagged for Drupal 7.60 under the assumption that that would be the next (non-security) release. Since it isn't, I'm just going ahead and committing it now for Drupal 7.55. It looks like a nice, self-contained fix.