Support more than one config names [#2449505]

Problem/Motivation

In ConfigTranslateForm.php we support only the first config name for now ($id = $mapper->getConfigNames()[0]). This should be extended for more config names.

Proposed resolution

Remaining tasks

User interface changes

API changes

Comment	File	Size	Author
#6	support_more_than_one-2449505-6-interdiff.txt	3.98 KB	sasanikolic
#6	support_more_than_one-2449505-6.patch	5.54 KB	sasanikolic
#6
#1	support_more_than_one-2449505-1.patch	7.64 KB	sasanikolic
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

sasanikolic CreditAttribution: sasanikolic at MD Systems GmbH commented 26 March 2015 at 15:20

Status:

Active

» Needs review

File	Size
support_more_than_one-2449505-1.patch	7.64 KB

Added the source and unit tests.

Comment #2

26 March 2015 at 15:27

Status:

Needs review

» Needs work

The last submitted patch, 1: support_more_than_one-2449505-1.patch, failed testing.

Comment #3

27 March 2015 at 08:10

Status:

Needs work

» Needs review

Berdir queued 1: support_more_than_one-2449505-1.patch for re-testing.

Comment #4

Berdir

German

Switzerland

CreditAttribution: Berdir at MD Systems GmbH commented 27 March 2015 at 08:12

Status:

Needs review

» Needs work

+++ b/sources/tmgmt_config/src/Tests/ConfigEntitySourceUiTest.php
@@ -171,6 +171,131 @@ class ConfigEntitySourceUiTest extends EntityTestBase {
+  /**
+   * Test more config names translation for a multiple checkout.
+   */
+  function testMoreConfigNamesTranslateTabMultipeCheckout() {

Hm, I'd say a single test is enough, we don't need to repeat single/multiple languages.

+++ b/sources/tmgmt_config/src/Tests/ConfigEntitySourceUnitTest.php
@@ -188,4 +188,45 @@ class ConfigEntitySourceUnitTest extends EntityUnitTestBase {
+    // $this->config('system.site')->set('slogan', 'Test slogan')->save();

you can remove this.

+++ b/sources/tmgmt_config/src/Tests/ConfigEntitySourceUnitTest.php
@@ -188,4 +188,45 @@ class ConfigEntitySourceUnitTest extends EntityUnitTestBase {
+    $this->assertEqual(\Drupal::config('user.mail')->get('status_canceled')['body'], $data['user.mail']['status_canceled']['body']['#translation']['#text']);
+    $this->assertEqual(\Drupal::config('user.mail')->get('password_reset')['body'], $data['user.mail']['password_reset']['body']['#translation']['#text']);

You can use . to simplify this, get('status_canceled.body').

Tests look good, though.