D7 won't update directly to D8, right? And even if it did, we'd first insist they update to the latest 7.x. If we remove all these update functions from webform.install, then when I need to add a new one to D7, I'll be assured that NOT addting it to D8 is correct. As of now, I think D8 is "missing" some from D7, which is inconsistent.

Comments

fenstrat’s picture

Title: D8: Remove D7-related hook_update_7xxx() functions » Remove D7-related hook_update_7xxx() functions
Status: Active » Fixed

Committed and pushed to 8.x-4.x. Thanks!

Thanks for creating this issue Dan, you're spot on, they were out of sync and needed to go. Keep in mind if 7.x-4.x makes schema changes they will need to be applied to 8.x-4.x (just not the update functions - or at least not until a stable 8.x-4.x release).

  • fenstrat committed 23c98f4 on 8.x-4.x
    Issue #2449485 by fenstrat: Remove D7-related hook_update_7xxx()...
DanChadwick’s picture

Right. Changes to webform_schema go into D8, but no hook_updates_N(). As time goes on, it's going to get harder to commit D7 patches without lots of modification. As agreed, I'll leave these open as Task / Patch to be Ported.

fenstrat’s picture

Yep, sounds good. Cheers Dan.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.