Currently, Radix only supports site-name in page.tpl.php. Theres an issue open for Panopoly to use radix as the installer theme (#2445359: Use Radix as installer theme), in which case the logo would need to be available in page.tpl.php to display on the installer page.

CommentFileSizeAuthor
#7 radix-site-logo-2448185-7.patch1.55 KBshadcn
#5 Homepage_Demo___Panopoly.png91.6 KBshadcn
#2 radix-site-logo-2448185-2.patch1.54 KBdsnopek
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cornifex’s picture

cornifex CreditAttribution: cornifex commented
Issue summary: View changes
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Status: Active » Needs work
FileSize
radix-site-logo-2448185-2.patch1.54 KB

Here's an adaption of some page.tpl.php changes that I did to add the logo for a client. However, this also needs to include some Sass changes, which I guess will need to go into compass_radix, so marking this as "Needs work".

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Status: Needs work » Needs review
FileSize
radix-site-logo-2448185-3.patch1.3 KB

The site slogan stuff from my client project snuck into that last patch. Here is a new patch that removes it!

Also, here is a PR against compass_radix which adds the necessary styling to make the logo fit inside the .navbar-branding:

https://github.com/arshad/compass_radix/pull/15/files

The idea is that a child theme could make .navbar-branding taller when in a desktop or tablet breakpoint, which will automatically scale the logo up to a bigger size. But under mobile (since this is "mobile first") it'll revert to its 50px height.

Please let me know what you think!

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
FileSize
Selection_049.png14.23 KB

Here's a screenshot from my -dev site:

shadcn’s picture

shadcn CreditAttribution: shadcn commented
FileSize
Homepage_Demo___Panopoly.png91.6 KB

Looks like it is breaking if both logo and site name are enabled.

Site name + logo

shadcn’s picture

shadcn CreditAttribution: shadcn commented

[Edited] : Removed duplicate post.

shadcn’s picture

shadcn CreditAttribution: shadcn commented
FileSize
radix-site-logo-2448185-7.patch1.55 KB

Should we go with something like this? (See patch)

This complies with Bootstrap markup: http://getbootstrap.com/components/#navbar-brand-image

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented

@arshadcn: Did you recompile Radix with my PR against compass_radix? Those changes are necessary too. See my screenshot in #4.

shadcn’s picture

shadcn CreditAttribution: shadcn commented

Yes I did patch using https://github.com/arshad/compass_radix/pull/15.patch

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented

Hrm, well, that's weird!

In any case, your patch in #7 works great for me! Matching Bootstrap markup would be good, sorry I didn't check that originally. And having a single link rather than two links is probably better for accessibility too!

I cleaned up my PR to compass_radix a bit for this new markup too:

https://github.com/arshad/compass_radix/pull/15

If the current patch and that PR works for you, we might have solved this one. :-)

shadcn’s picture

shadcn CreditAttribution: shadcn commented
Status: Needs review » Fixed

Looking good. Committed. Thanks.

  • arshadcn committed f0e4679 on 7.x-3.x authored by dsnopek 
    Issue #2448185 by arshadcn, dsnopek: Support site logo by default

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.