Problem/Motivation

I've experienced minor problem when styling Execute PHP admin form because it doesn't have #actions container, which is common practice in all admin forms.

Proposed resolution

Add 'actions' parent level to 'Execute' button. Change:

$form['execute']['op'] = array('#type' => 'submit', '#value' => t('Execute'));

to:

$form['execute']['actions'] = array('#type' => 'actions');
$form['execute']['actions']['op'] = array('#type' => 'submit', '#value' => t('Execute'));

Remaining tasks

n/a

User interface changes

Button will follow admin theme standards, ex. in 'Seven' will be aligned to the right.

API changes

n/a

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

zaporylie’s picture

Assigned: zaporylie » Unassigned
Status: Active » Needs review
FileSize
1001 bytes

Here is a patch.

jacob.embree’s picture

Status: Needs review » Reviewed & tested by the community

Shall we open another issue to do the rest of the forms throughout the project or expand this one?

salvis’s picture

Version: 7.x-1.x-dev » 8.x-1.x-dev
Status: Reviewed & tested by the community » Active

Yes, it would be really nice to have them all in one issue!

However, this is a D8-first issue. Is there any work needed in D8?

jacob.embree’s picture

jacob.embree’s picture

Title: Add #actions container to Execute PHP submit button » Add #actions container to submit buttons

  • salvis committed fc4bcaa on 8.x-1.x authored by jacob.embree
    Issue #2448063 by jacob.embree, zaporylie: Add #actions container to...

  • salvis committed 7fe21b2 on 7.x-1.x authored by jacob.embree
    Issue #2448063 by jacob.embree, zaporylie: Add #actions container to...
salvis’s picture

Status: Needs review » Fixed

Thank you, jacob.embree and zaporylie!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.