Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The user module tests didn't pass before this review for several reasons. After review the tests now passes all except for default timezone check.
$this->assertEqual($user->timezone, variable_get('date_default_timezone', NULL), t('Correct timezone field.'));
After a look at the code this appears to be a bug.
Other than that this test has been cleaned up quiet a bit. I removed the access rules test since that is no longer in core.
As a note UserValidationTestCase
is full of unit tests. Once unit testing is implemented they should be moved.
Comment | File | Size | Author |
---|---|---|---|
simpletest_review_user.patch | 17.76 KB | boombatower | |
Comments
Comment #1
catchWas going to open an issue for access rules and you've beaten me to it!
Comment #2
boombatower CreditAttribution: boombatower commentedCommitted.
Comment #3
Anonymous (not verified) CreditAttribution: Anonymous commentedAutomatically closed -- issue fixed for two weeks with no activity.