The user module tests didn't pass before this review for several reasons. After review the tests now passes all except for default timezone check.

$this->assertEqual($user->timezone, variable_get('date_default_timezone', NULL), t('Correct timezone field.'));

After a look at the code this appears to be a bug.

Other than that this test has been cleaned up quiet a bit. I removed the access rules test since that is no longer in core.

As a note UserValidationTestCase is full of unit tests. Once unit testing is implemented they should be moved.

CommentFileSizeAuthor
simpletest_review_user.patch17.76 KBboombatower
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

catch’s picture

Was going to open an issue for access rules and you've beaten me to it!

boombatower’s picture

Status: Needs review » Fixed

Committed.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.