On a clean install Module Filter 7.x-2.0 displays overlapping text (Links, Description) in the ember theme only.

screenshot

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

zxaos’s picture

Issue summary: View changes
zxaos’s picture

Issue summary: View changes
zxaos’s picture

Issue summary: View changes
chiebert’s picture

Found this, too - it's because of lines 261-270 in sass/component/_tables.scss:

/* on these forms/pages make column 4 widest */
form#system-modules {
  th,
  td {
    &:nth-child(4) {
      width: 100%;
      min-width: 300px;
    }
  }
}

That's supposed to target the Description column, but because of how module_filter reprocesses the table, it's now targeting the 'Links' column.

It turns out that, fortunately, module_filter adds a .module-filter-tabs-processed class to the table itself, so one should be able to add an override for this case. Of course, it would be even better if that column's <th> and <td> elements received something like a 'description' class, so this line could target it more consistently...

chiebert’s picture

Status: Active » Needs review
FileSize
4.31 KB

... as, in fact, module_filter does... So, here's a possible patch, but it's not perfect. At least it gets the descriptions back on the screen, though...

chiebert’s picture

Cleaned up extraneous stuff in the patch.

chiebert’s picture

Aaaand this is better patch, I think - better reset of the non-module-filter version, which consequently makes it nicer for the module filter version...

rosemeria’s picture

Applied and tested patch #7 in a Drupal Commons Distro (fresh local install) - the distro uses Ember as admin theme. Patch worked fine, module descriptions and links visible - looks good.

Leeteq’s picture

Version: 7.x-2.0-alpha3 » 7.x-2.x-dev
Priority: Normal » Major

  • Bcwald committed ca20eb3 on 7.x-2.x authored by chiebert
    Issue #2447507 by chiebert: Module Filter displays overlapping text
    
Bcwald’s picture

Looks good, This patch is now in dev.

Bcwald’s picture

Status: Needs review » Closed (fixed)