Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Comment | File | Size | Author |
---|---|---|---|
#7 | ember-module-filter-column-widths-fix-2447507-7.patch | 1.51 KB | chiebert |
Screen Shot 2015-03-06 at 12.39.22.png | 81.47 KB | zxaos |
Comments
Comment #1
zxaos CreditAttribution: zxaos commentedComment #2
zxaos CreditAttribution: zxaos commentedComment #3
zxaos CreditAttribution: zxaos commentedComment #4
chiebert CreditAttribution: chiebert commentedFound this, too - it's because of lines 261-270 in sass/component/_tables.scss:
That's supposed to target the Description column, but because of how module_filter reprocesses the table, it's now targeting the 'Links' column.
It turns out that, fortunately, module_filter adds a
.module-filter-tabs-processed
class to the table itself, so one should be able to add an override for this case. Of course, it would be even better if that column's<th>
and<td>
elements received something like a 'description' class, so this line could target it more consistently...Comment #5
chiebert CreditAttribution: chiebert commented... as, in fact, module_filter does... So, here's a possible patch, but it's not perfect. At least it gets the descriptions back on the screen, though...
Comment #6
chiebert CreditAttribution: chiebert commentedCleaned up extraneous stuff in the patch.
Comment #7
chiebert CreditAttribution: chiebert commentedAaaand this is better patch, I think - better reset of the non-module-filter version, which consequently makes it nicer for the module filter version...
Comment #8
rosemeria CreditAttribution: rosemeria commentedApplied and tested patch #7 in a Drupal Commons Distro (fresh local install) - the distro uses Ember as admin theme. Patch worked fine, module descriptions and links visible - looks good.
Comment #9
Leeteq CreditAttribution: Leeteq commentedComment #11
Bcwald CreditAttribution: Bcwald commentedLooks good, This patch is now in dev.
Comment #12
Bcwald CreditAttribution: Bcwald commented